-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolyComm: use method len directly instead of chunks.len #2659
PolyComm: use method len directly instead of chunks.len #2659
Conversation
86aeee7
to
7f9f96c
Compare
`len()` on PolyComm is exactly implemented as `chunks.len()` It is part of a work abstracting the structure `PolyComm`, and remove the access to the field `chunks`.
a4840bc
to
b2a22a7
Compare
@@ -239,11 +239,11 @@ where | |||
let alpha = alpha_chal.to_field(endo_r); | |||
|
|||
//~ 1. Enforce that the length of the $t$ commitment is of size 7. | |||
if self.commitments.t_comm.chunks.len() > chunk_size * 7 { | |||
if self.commitments.t_comm.len() > chunk_size * 7 { | |||
return Err(VerifyError::IncorrectCommitmentLength( | |||
"t", | |||
chunk_size * 7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but this 7 should be a PERMUTS
or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is because we do have a degree 8, and therefore 7 chunks for the quotient polynomial. It doesn't seem to be related to the permutations (even though, because we do use degree 8 constraints, we do use 7 permutations).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2659 +/- ##
==========================================
- Coverage 72.98% 72.97% -0.02%
==========================================
Files 244 244
Lines 57777 57776 -1
==========================================
- Hits 42170 42163 -7
- Misses 15607 15613 +6 ☔ View full report in Codecov by Sentry. |
len()
on PolyComm is exactly implemented aschunks.len()
It is part of a work abstracting the structurePolyComm
, and remove the access to the fieldchunks
.