Remove commitment shifting functionality

[volhovm]

This removes the unused and obsolete functionality of shifted polynomial commitments from the poly-commitments crate, and from its usages in kimchi.

• Resolves Remove obsolete/unused shifting functionality MinaProtocol/mina#14628
• mina PR counterpart: Remove commitment shifting, but only in proof-systems (Part 1) MinaProtocol/mina#15071

Probably better to review commit-by-commit.

[dannywillems]

I would not merge it as it requires changes in o1js-bindings.

[volhovm]

@dannywillems Does it? I'm not exactly sure -- if you see the mina PR (MinaProtocol/mina#15071), the changes in bindings there are minimal/don't propagate upwards. What's the issue exactly?

[dannywillems]

@dannywillems Does it? I'm not exactly sure -- if you see the mina PR (MinaProtocol/mina#15071), the changes in bindings there are minimal/don't propagate upwards. What's the issue exactly?

See https://github.com/o1-labs/o1js-bindings/blob/main/crypto/bindings/conversion-core.ts#L118. You should update o1js-bindings in o1js and bump up mina in o1js. Otherwise, the next time someone will bump up develop in o1js, they will have errors.

[volhovm]

@dannywillems OK thanks for the heads-up, will do.

[volhovm]

@dannywillems was addressed in o1-labs/o1js-bindings#250 o1-labs/o1js#1290, everything seems to work well. Merging!