Rename equals_zero to test_zero

o1-labs · Dec 5, 2023 · 96b2cfa · 96b2cfa
1 parent 2bc2de2
commit 96b2cfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/optimism/src/mips/interpreter.rs b/optimism/src/mips/interpreter.rs
@@ -532,11 +532,7 @@ pub trait InterpreterEnv {
     ///
     /// There are no constraints on the returned value; callers must assert the relationship with
     /// `x`.
-    unsafe fn equals_zero(
-        &mut self,
-        x: &Self::Variable,
-        position: Self::Position,
-    ) -> Self::Variable;
+    unsafe fn test_zero(&mut self, x: &Self::Variable, position: Self::Position) -> Self::Variable;
 
     fn copy(&mut self, x: &Self::Variable, position: Self::Position) -> Self::Variable;
 
@@ -763,7 +759,7 @@ pub fn interpret_itype<Env: InterpreterEnv>(env: &mut Env, instr: ITypeInstructi
             let equals = {
                 // FIXME: Requires constraints
                 let pos = env.alloc_scratch();
-                unsafe { env.equals_zero(&(rs - rt), pos) }
+                unsafe { env.test_zero(&(rs - rt), pos) }
             };
             let offset = (Env::constant(1) - equals.clone()) * Env::constant(4) + equals * offset;
             let addr = {

diff --git a/optimism/src/mips/witness.rs b/optimism/src/mips/witness.rs
@@ -227,11 +227,7 @@ impl<Fp: Field> InterpreterEnv for Env<Fp> {
         res
     }
 
-    unsafe fn equals_zero(
-        &mut self,
-        x: &Self::Variable,
-        position: Self::Position,
-    ) -> Self::Variable {
+    unsafe fn test_zero(&mut self, x: &Self::Variable, position: Self::Position) -> Self::Variable {
         let res = if *x == 0 { 1 } else { 0 };
         self.write_column(position, res.into());
         res