Pin the numpy version to avoid gltf import failure#53
Open
Amit-Tomar wants to merge 1 commit into
Open
Conversation
Fix for issue : nytimes#52
Contributor
|
Thanks @Amit-Tomar - have you tested this with all images? I suspect this may cause issues with older versions of Blender and would be good to verify that prior to merging and deploying new images |
Author
|
@juniorxsound What is the recommended way to test this with all previous versions ? Generate all images and verify by running the commands mentioned in wiki manually ? or some kind of automation is in place ? Also wondering if instead of fixing the numpy version for all images, will it make more sense to keep the numpy version Bender version specific ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue : #52