VPN-4633: SOCKS5 proxy is not shutting-down correctly. #4148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pronebird I am still looking into the root-cause of this issue, which is the obvious file in use. So I don't think we are closing down properly. |
trojanfoe
force-pushed
the
bug/vpn-4688-socks5-directory
branch
from
6b38c5a to
c1b3404
Compare
trojanfoe
changed the title
trojanfoe
force-pushed
the
bug/vpn-4688-socks5-directory
branch
from
4b8c08e to
afcd73c
Compare
Contributor
Author
|
@pronebird I cannot reproduce the root cause on Windows or macOS, so I would like to merge this change until we have more reports from actual users. |
pronebird
approved these changes
Dec 10, 2025
| } | ||
|
|
||
| // Enable SOCKS5 proxy request | ||
| // TODO: Change arguments to EnableSocks5Request (at the time of writing I didn't want to disturb the client code) |
Collaborator
There was a problem hiding this comment.
What needs to be changed?
| listen_address: String::new(), | ||
| }); | ||
| .ok_or(ConversionError::NoValueSet( | ||
| "EnableSocks5Request.socks5_settings", |
trojanfoe
force-pushed
the
bug/vpn-4688-socks5-directory
branch
from
d2bfe6b to
dca9e25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
JIRA-VPN-4633
Description
SOCKS5 proxy is not shutting-down correctly.
Checklist:
Screenshots (optional, if UI related)
This change is