Audit: Add contract tests for JSON endpoints#450
Merged
ngjunsiang merged 1 commit intoweeklyfrom Apr 9, 2026
Merged
Conversation
Issue #427: Routes and Authentication - Contract Tests Tests: - TestAuditHealthContract - health endpoint (no auth required) - TestAuditTracesIngestContract - POST /traces ingest endpoints - TestAuditTracesListContract - GET /traces list endpoint - TestAuditTracesGetTreeContract - GET /traces/<id> tree endpoint - TestAuditSpansListContract - GET /traces/<id>/spans/ list endpoint - TestAuditSpanGetContract - GET /traces/<id>/spans/<span_id> detail endpoint - TestAuditTracesSearchContract - GET /traces/search filter endpoint Infrastructure: - Add audit_app to ServiceManager for testing - Fix authentication to apply only to traces blueprint (not health) - Moved before_request hook from parent bp to traces_blueprint - Health endpoint now correctly requires no authentication Fixes authentication bug where health endpoint was incorrectly requiring authentication due to before_request being applied to parent blueprint instead of traces blueprint. Note: Some tests have isolation issues due to data persistence. Tests pass when run individually. Refs: #427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds HTTP contract tests for all audit JSON endpoints (issue #427).
Tests Added (27 tests)
TestAuditHealthContract- Health check (no auth required)TestAuditTracesIngestContract- POST /traces ingestTestAuditTracesListContract- GET /traces listTestAuditTracesGetTreeContract- GET /traces/ treeTestAuditSpansListContract- GET /traces//spans listTestAuditSpanGetContract- GET /traces//spans/<span_id> detailTestAuditTracesSearchContract- GET /traces/search filteringInfrastructure Changes
audit_apptoServiceManagerfor test supportbefore_requesthook was on parent blueprinttraces_blueprintonlyAcceptance Criteria ✅
Known Issue
Some tests have isolation issues when run in a suite due to data persistence.
Tests pass when run individually. This will be addressed in a follow-up
by adding
reset_test_data()calls or using non-shared service instances.Related
🤖 Generated with Claude Code