Skip to content

perf: iterate array guards by index - #347

Merged
nyaomaru merged 3 commits into
mainfrom
perf/indexed-array-traversal
Oct 16, 2026
Merged

nyaomaru merged 3 commits into
mainfrom
perf/indexed-array-traversal

Conversation

@nyaomaru

@nyaomaru nyaomaru commented Oct 16, 2026 •

Copy link
Copy Markdown
Owner

Close #338

Summary

Iterate array guards by index.

Description

  • Replace iterator-based everyBrandedArrayValue traversal with an indexed loop.
  • Preserve sparse-array rejection by reading holes as undefined.
  • Preserve Array subclass support and bypass overridden Symbol.iterator implementations.

@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
is-kit-docs Ready Ready Preview Oct 16, 2026 3:11pm UTC

Request Review

@nyaomaru

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T15:19:51.566307Z 64c0121 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 64c01217c5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@nyaomaru
nyaomaru marked this pull request as ready for review October 16, 2026 15:30
@nyaomaru
nyaomaru merged commit bc3dc39 into main Oct 16, 2026
12 checks passed
@nyaomaru
nyaomaru deleted the perf/indexed-array-traversal branch October 16, 2026 15:58

This branch was successfully deployed

1 active deployment
Preview — 64c01217 Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf(arrayOf): evaluate indexed iteration instead of iterator traversal

1 participant