Skip to content

fix: Adjust selected range when set selection=exclusive#687

Merged
kiyoon merged 1 commit intonvim-treesitter:mainfrom
afgomez:push-mytzklwxxlun
Feb 28, 2025
Merged

fix: Adjust selected range when set selection=exclusive#687
kiyoon merged 1 commit intonvim-treesitter:mainfrom
afgomez:push-mytzklwxxlun

Conversation

@afgomez
Copy link
Copy Markdown
Contributor

@afgomez afgomez commented Sep 8, 2024

Fixes #488

When the user has set selection=exclusive the selection was one character short. This PR addresses that.

Note that this PR fixes it in the main branch. The master branch uses a function outside of this repo, so it cannot be fixed here.

@afgomez afgomez changed the title Adjust selected range if set selection? is exclusive Adjust selected range when set selection=exclusive Sep 8, 2024
@clason clason added the NEXT issues and PRs relating to the 1.0 refactor on `main` label Sep 8, 2024
@afgomez afgomez changed the title Adjust selected range when set selection=exclusive fix: Adjust selected range when set selection=exclusive Sep 8, 2024
@kiyoon kiyoon merged commit fa32a45 into nvim-treesitter:main Feb 28, 2025
kiyoon pushed a commit that referenced this pull request Nov 12, 2025
Fixes #827 . The changes are similar to the ones in #812 , but they are
different from the function mentioned in a comment of that PR
(#812 (comment))
because said function assumes that the range returned is end-inclusive,
while this plugin currently is treating the range as end_exclusive.

This bug was surfaced by #687 (because and `end_row, end_col` pair like
`4, 0` becomes `4, -1` after the change), but this wasn't working
properly before #687 either. The behavior before that PR was to also
select the first character of the next line (so, one character after the
newline).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NEXT issues and PRs relating to the 1.0 refactor on `main`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants