add latent weight for hdmap_bbox control for multi view#102
Open
cshnv wants to merge 1 commit into
Open
Conversation
Contributor
|
Please add a PR description along with verification evidence. |
Contributor
|
Changes look good. Thanks for putting everything behind a feature-flag! Please run the following, then I can approve:
# E2E test inference
just test-single "tests/docs_test.py::test_level_2[auto_multiview]"
# Smoke test post-training
just test-single "tests/docs_test.py::test_level_0[post-training_auto_multiview]" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR that try to mitigate the hallucination by using a latent weight from foreground mask.
We tested on 10 cases and check by eye to see some improvements. Further quantitative evaluation is under going.