fix: wrong checkpoints path for DepthAnythingModel when input control is null#207
Open
DK-DARKmatter wants to merge 1 commit into
Open
fix: wrong checkpoints path for DepthAnythingModel when input control is null#207DK-DARKmatter wants to merge 1 commit into
DK-DARKmatter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried with examples given like:
I got following error:
The correct relative path should be:
if we use script to download all dependencies. The code here forget to make a path join so it does not read from the correct path, which I think has a different behavior from doc.
This is a relative simple fix, please tell me if we have a more elegant way to fix this.
BTW, I think this issue #79 has the same problem as this one. Maybe we could fix that too.