This repository was archived by the owner on Dec 3, 2025. It is now read-only.
PICBIR9W-1166: Fix reason1 multiview#152
Merged
spectralflight merged 15 commits intoAug 29, 2025
Merged
Conversation
spectralflight
changed the title
spectralflight
changed the title
codeJRV
reviewed
Aug 29, 2025
codeJRV
reviewed
Aug 29, 2025
| loss weights per sigma noise level | ||
| """ | ||
| return (sigma**2 + self.pipe.sigma_data**2) / (sigma * self.pipe.sigma_data) ** 2 | ||
| return (1 + sigma) ** 2 / sigma**2 |
There was a problem hiding this comment.
is ( sigma == self.pipe.sigma_data )? Is there a possibility when running in batch inference mode, there is no self.pipe and it defaults to 0?
Collaborator
Author
There was a problem hiding this comment.
No clue. Lyne told me to copy this from i4. This is how i4 is as well. No idea why there are 2 variables with identical names.
pjannaty
approved these changes
Aug 29, 2025
zhengkw18
pushed a commit
to zhengkw18/cosmos-predict2
that referenced
this pull request
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #132
Verification
Almost all changes are all behind a feature-flag.
GitLab CI (failure is also on main):
pipelines/34096713Jira Ticket (contains verification evidence):
PICBIR9W-1166