Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions py_backwards/transformers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from .formatted_values import FormattedValuesTransformer
from .functions_annotations import FunctionsAnnotationsTransformer
from .starred_unpacking import StarredUnpackingTransformer
from .async_await import AsyncAwaitTransformer
from .variables_annotations import VariablesAnnotationsTransformer
from .yield_from import YieldFromTransformer
from .return_from_generator import ReturnFromGeneratorTransformer
Expand All @@ -23,6 +24,7 @@
# 3.4
DictUnpackingTransformer,
StarredUnpackingTransformer,
AsyncAwaitTransformer,
# 3.2
YieldFromTransformer,
ReturnFromGeneratorTransformer,
Expand Down
64 changes: 64 additions & 0 deletions py_backwards/transformers/async_await.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
from typed_ast import ast3 as ast
from .base import BaseNodeTransformer


ASYNCIO_MODULE = '__py_backwards_asyncio__'

def asyncio_decorator():
return ast.Attribute(
value=ast.Name(
id=ASYNCIO_MODULE,
ctx=ast.Load(),
),
attr='coroutine',
)


def splice(fn, vars):
for i, v in enumerate(vars):
nv = fn(v)
if nv is None:
yield v
else:
yield nv
for v in vars[i:]:
yield v
break


class AsyncAwaitTransformer(BaseNodeTransformer):
"""Compiles:
async def ham():
await foo()
To

import asyncio as __py_backwards_asyncio__

@__py_backwards_asyncio__.coroutine
def ham():
yield from foo()
"""
target = (3, 4)

def visit_Module(self, n: ast.Module) -> ast.Module:
self._tree_changed = True
def dosplice(v):
# insert just after the first node that's not a future import.
if not (isinstance(v, ast.ImportFrom) and v.module == '__future__'):
return ast.Import(names=[ast.alias('asyncio', ASYNCIO_MODULE)])

return self.generic_visit(ast.Module(body=list(splice(dosplice, n.body))))

def visit_AsyncFunctionDef(self, node: ast.AsyncFunctionDef) -> ast.FunctionDef:
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this function is being called, but the return value is being ignored. :(

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a bug in typed ast.
Maybe it would be better to use lower-level api, like in https://github.com/nvbn/py-backwards/blob/master/py_backwards/transformers/variables_annotations.py#L20

self._tree_changed = True
return self.generic_visit(ast.FunctionDef(
name=node.name,
args=node.args,
body=node.body,
decorator_list=node.decorator_list + [asyncio_decorator()],
returns=node.returns,
))

def visit_Await(self, node: ast.Await) -> ast.Await:
self._tree_changed = True
return self.generic_visit(ast.YieldFrom(value=node.value))
27 changes: 27 additions & 0 deletions tests/transformers/test_async_await.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import pytest
from py_backwards.transformers.async_await import AsyncAwaitTransformer


@pytest.mark.parametrize('before, after', [
('''
async def fn():
await range(10)
''', '''import asyncio as __py_backwards_asyncio__

@__py_backwards_asyncio__.coroutine
def fn():
yield from range(10)
'''),
('''
async def fn():
a = await range(10)
''', '''import asyncio as __py_backwards_asyncio__

@__py_backwards_asyncio__.coroutine
def fn():
a = yield from range(10)
'''),
])
def test_transform(transform, ast, before, after):
code = transform(AsyncAwaitTransformer, before)
assert ast(code) == ast(after)