Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It reduces build reproducibility via .python-version and drops a previously-present Windows filename safety hook in the new prek config.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates pinned dependencies and developer tooling configuration for the nvdaL10n project, including refreshing the uv lockfile and migrating local hook/type-check tooling away from pre-commit/pyright.
Changes:
- Update runtime dependencies (e.g.,
lxml,crowdin-api-client,markdown,pymdown-extensions) and refreshuv.lock. - Replace
.pre-commit-config.yamlwithprek.toml, and swap dev tools toprek+ty(plusruffbump). - Add markdownlint configuration and update the automatic release workflow’s checkout action version.
File summaries
| File | Description |
|---|---|
uv.lock |
Refreshes locked dependency set and updates dev-tool packages to match the new toolchain. |
pyproject.toml |
Bumps pinned dependency versions and replaces pre-commit/pyright configuration with prek + ty. |
prek.toml |
Introduces prek configuration to replace the removed pre-commit config. |
.python-version |
Changes the Python version pin used by CI/local tooling from a patch pin to a minor pin. |
.pre-commit-config.yaml |
Removed in favor of prek.toml. |
.markdownlint.jsonc |
Adds markdownlint rule configuration. |
.github/workflows/automaticRelease.yaml |
Updates actions/checkout major version for the release workflow. |
Review details
- Files reviewed: 6/7 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "markdown-link-attr-modifier==0.2.1", | ||
| "mdx-gh-links==0.4", | ||
| "mdx-truly-sane-lists==1.3", | ||
| "mdx_truly_sane_lists==1.3", | ||
| "nh3==0.2.19", | ||
| "pymdown-extensions==10.16.1", | ||
| "pymdown-extensions==11.0.1", | ||
| "requests==2.33.0", |
|
cc: @CyrilleB79 You may be interested in Copilot suggestion about using Python 3.13.12 instead of a more flexible version range. I've rejected the suggestion. |
|
seems like the lint is failing with the new rules |
|
@seanbudd wrote: seems like the lint is failing with the new rules I'll merge another branch here, with files linted and updated according to changes in NVDA core. |
|
@seanbudd , I've built user docs in NVDA with this new change. The pre-commit config is removed, so the corresponding check will fail, but I think that this is ready now. |
|
There's still merge conflicts preventing merge |
| BMI.po: 300 | ||
| BMI.pot: 300 | ||
| BMI.xliff: 302 | ||
| BrailleExtender.po: 592 |
There was a problem hiding this comment.
I think that changes should be here. Do you have any suggestion for this, for example, creating a new PR with the updated configuration,?
There was a problem hiding this comment.
they still seem to be in this diff
There was a problem hiding this comment.
I updated the config file intentionally, since more add-ons may have been added. If you want, I can reset it to main.
There was a problem hiding this comment.
I think they should be updated in different PR
Issue number
Discussed in nvaccess/nvda#20777
Description
Testing performed
Linting locally.