Skip to content

Update dependencies - #9

Open
nvdaes wants to merge 10 commits into
nvaccess:mainfrom
nvdaes:updateDeps
Open

nvdaes wants to merge 10 commits into
nvaccess:mainfrom
nvdaes:updateDeps

Conversation

@nvdaes

@nvdaes nvdaes commented Sep 5, 2026

Copy link
Copy Markdown

Issue number

Discussed in nvaccess/nvda#20777

Description

  • Updated dependencies in pyproject.toml, based on the NVDA repo.
  • Switch to prek, based on NVDA pre-commit configuration, and the prek configuration in addonTemplate.
  • Updated checkout action to version 7.
    • Updated Python version file.
  • Updated config file for the NVDA add-ons Crowdin project.
  • Added linting configuration for markdown.

Testing performed

Linting locally.

Copilot AI lite review requested due to automatic review settings September 5, 2026 10:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It reduces build reproducibility via .python-version and drops a previously-present Windows filename safety hook in the new prek config.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates pinned dependencies and developer tooling configuration for the nvdaL10n project, including refreshing the uv lockfile and migrating local hook/type-check tooling away from pre-commit/pyright.

Changes:

  • Update runtime dependencies (e.g., lxml, crowdin-api-client, markdown, pymdown-extensions) and refresh uv.lock.
  • Replace .pre-commit-config.yaml with prek.toml, and swap dev tools to prek + ty (plus ruff bump).
  • Add markdownlint configuration and update the automatic release workflow’s checkout action version.
File summaries
File Description
uv.lock Refreshes locked dependency set and updates dev-tool packages to match the new toolchain.
pyproject.toml Bumps pinned dependency versions and replaces pre-commit/pyright configuration with prek + ty.
prek.toml Introduces prek configuration to replace the removed pre-commit config.
.python-version Changes the Python version pin used by CI/local tooling from a patch pin to a minor pin.
.pre-commit-config.yaml Removed in favor of prek.toml.
.markdownlint.jsonc Adds markdownlint rule configuration.
.github/workflows/automaticRelease.yaml Updates actions/checkout major version for the release workflow.
Review details
  • Files reviewed: 6/7 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .python-version
Comment thread prek.toml
Comment thread pyproject.toml Outdated
Comment on lines 28 to 33
"markdown-link-attr-modifier==0.2.1",
"mdx-gh-links==0.4",
"mdx-truly-sane-lists==1.3",
"mdx_truly_sane_lists==1.3",
"nh3==0.2.19",
"pymdown-extensions==10.16.1",
"pymdown-extensions==11.0.1",
"requests==2.33.0",
@nvdaes

nvdaes commented Sep 5, 2026

Copy link
Copy Markdown
Author

cc: @CyrilleB79

You may be interested in Copilot suggestion about using Python 3.13.12 instead of a more flexible version range. I've rejected the suggestion.

@seanbudd seanbudd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nvdaes

@seanbudd

seanbudd commented Sep 7, 2026

Copy link
Copy Markdown
Member

seems like the lint is failing with the new rules

@nvdaes

nvdaes commented Sep 7, 2026

Copy link
Copy Markdown
Author

@seanbudd wrote:

seems like the lint is failing with the new rules

I'll merge another branch here, with files linted and updated according to changes in NVDA core.

@seanbudd
seanbudd marked this pull request as draft September 8, 2026 23:10
@nvdaes
nvdaes marked this pull request as ready for review September 9, 2026 03:06
@nvdaes

nvdaes commented Sep 9, 2026

Copy link
Copy Markdown
Author

@seanbudd , I've built user docs in NVDA with this new change. The pre-commit config is removed, so the corresponding check will fail, but I think that this is ready now.

@seanbudd

seanbudd commented Sep 11, 2026

Copy link
Copy Markdown
Member

There's still merge conflicts preventing merge

@seanbudd seanbudd closed this Sep 11, 2026
@seanbudd seanbudd reopened this Sep 11, 2026
Comment thread config/addonTemplate.yaml Outdated
BMI.po: 300
BMI.pot: 300
BMI.xliff: 302
BrailleExtender.po: 592

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should these changes be here?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that changes should be here. Do you have any suggestion for this, for example, creating a new PR with the updated configuration,?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deanbudd, conflicts are fixed now.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they still seem to be in this diff

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the config file intentionally, since more add-ons may have been added. If you want, I can reset it to main.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should be updated in different PR

@nvdaes

nvdaes commented Sep 18, 2026

Copy link
Copy Markdown
Author

@seanbudd wrote:

I think they should be updated in different PR

Done in PR #12 . Feel free to review it when you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants