refactor(Form): use formwerk
#5454
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the convention used in other form components.
Member
|
Shall we merge this into #5379? |
genu
reviewed
Nov 25, 2025
Comment on lines
+166
to
+173
| disabled, | ||
| required: props.required, | ||
| controlType: 'UFileUpload' | ||
| }) |
Member
There was a problem hiding this comment.
@romhml What do you think about abstracting useCustomControl<T> inside of the useFormField composable?
That way we can better standardize the setting of touched, blurred and dirty fields when users implement their own custom form fields?
I'm thinking something like this: https://github.com/nuxt/ui/blob/4dea1067caa0d3e973d329a365945dc208c163e8/src/runtime/composables/useFormField.ts
Member
I think we'd close the other in favor of this, ultimately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up from #5379 to refactor and simplify the Form component by using Formwerk to handle the core validation and form logic.
🔗 Linked issue
❓ Type of change
📚 Description
📝 Checklist