Skip to content

feat(FormField): add required field support across form components #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 33 commits into
base: v3
Choose a base branch
from
Open

feat(FormField): add required field support across form components #4687

wants to merge 33 commits into from
+674 −650

Conversation

rdjanuar
Copy link
Contributor

@rdjanuar rdjanuar commented Aug 9, 2025 •
edited by benjamincanac
Loading

🔗 Linked issue

Resolves #4529

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

rdjanuar and others added 24 commits July 16, 2025 11:33
@rdjanuar
feat(FormField): add required field support across form components
f9aaa99
@rdjanuar
Merge branch 'v3' into fix/issues-4529
448b264
@rdjanuar
fix(form): simplify required field logic by moving it to useFormField
6889618
@rdjanuar
Merge branch 'v3' into fix/issues-4529
52e4dad
@benjamincanac
Merge branch 'v3' into pr/4534
9846225
@benjamincanac
up
1759c52
@benjamincanac
up
de43537
@rdjanuar
Merge branch 'v3' into fix/issues-4529
52303fe
@rdjanuar
test(FormField): add required binding test
a79bb6f
@rdjanuar
refactor(FormField): improve type safety for required fields
ef955d4
@rdjanuar
up
0b09606
@rdjanuar
up
d6914fb
@rdjanuar
up
e5ab984
@rdjanuar
up
27ad4b8
@rdjanuar
fix(FormField): revert FieldProps
cacb095
@rdjanuar
fix(docs): revert form component example
8519389
@rdjanuar
Merge branch 'v3' into fix/issues-4529
9cd9960
@rdjanuar
Merge branch 'v3' into fix/issues-4529
dc84947
@rdjanuar
up
778e62b
@rdjanuar
test(FormField): fix missing import
885bb1d
@rdjanuar
test(FormField): update test to handle FileUpload component
38ff468
@rdjanuar
Merge branch 'v3' into fix/issues-4529
720e2e2
@rdjanuar
Merge branch 'v3' into fix/issues-4529
f9884cb
@rdjanuar
fix: lint
eed4511
@rdjanuar rdjanuar requested a review from benjamincanac as a code owner August 9, 2025 18:30
@rdjanuar rdjanuar changed the title Fix/issues 4529 feat(FormField): add required field support across form components Aug 9, 2025
@rdjanuar
Copy link
Contributor Author

rdjanuar commented Aug 9, 2025 •
edited
Loading

sorry i make pull request again because i`m accidently remove my repository @benjamincanac

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 9, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@4687

commit: 7ef124c

@benjamincanac benjamincanac requested a review from romhml August 14, 2025 10:59
@benjamincanac benjamincanac added the v3 #1289 label Aug 27, 2025
@benjamincanac benjamincanac force-pushed the v3 branch 2 times, most recently from a3fc9ca to 13eecb1 Compare September 19, 2025 12:37
@benjamincanac
Copy link
Member

@rdjanuar Would you be willing to move this PR to v4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac benjamincanac approved these changes

@romhml romhml Awaiting requested review from romhml

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setting required="true" on a <UFormField> should also set it's child required to true

3 participants

@rdjanuar @benjamincanac @HugoRCD