feat(Calendar): add week numbers #4555
Open
+1,360
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure if we truly want these, but I've made them just in case, I only undestand cs, sk and en so the rest are AI translations... I did some research and I'm not sure if we really need this header as it is not space efficient and most users know that the leftmost column in calendar is used for week numbers.
|
I'm not sure if we want the header for the week number column, so I put it inside a separate commit to make it easier to remove if necessary. We need to wait for the next RekaUI release where the |
commit: |
J-Michalek
commented
Jul 21, 2025
test/components/Calendar.spec.ts
Outdated
| ['without fixedWeeks', { props: { fixedWeeks: false } }], | ||
| ['without monthControls', { props: { monthControls: false } }], | ||
| ['without yearControls', { props: { yearControls: false } }], | ||
| ['without weekNumbers', { props: { weekNumbers: true } }], |
There was a problem hiding this comment.
@J-Michalek This is wrong as the title should be "with weekNumbers".
…dar-week-numbers
|
Shall we close this to take advantage of unovue/reka-ui#1959 instead? |
|
We can leave this open, it just needs some finishing touches now that the utility function is released. I will look into this this week for sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves: #4231
❓ Type of change
📚 Description
I've added the week numbers to the leftmost column of the calendar.
📝 Checklist