Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: relax nuxt peerDeps version to support edge releases #677

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 17, 2024

Related nuxt/nuxt#27597

Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: b5c3a18
Status: ✅  Deploy successful!
Preview URL: https://3805c1be.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-ci-relax-nuxt.nuxt-devtools.pages.dev

View logs

@antfu antfu changed the title ci: relax nuxt peerDeps version on edge release ci: relax nuxt peerDeps version to support edge releases Jun 17, 2024
@antfu antfu requested a review from pi0 June 17, 2024 10:00
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (not tested but guess would work)

@pi0
Copy link
Member

pi0 commented Jun 17, 2024

one thing might be tricky: pnpm undrestands nuxt as npm:nuxt (not npm:nuxt-nightly) that's why we have this problem in first place... so it might still reproduce same issue but not sure about * behavior ...

@antfu
Copy link
Member Author

antfu commented Jun 17, 2024

Yeah, that's also my concern as well - it's indeed not clear how they would behave. Let me double-check if we can remove it entirely

@antfu antfu merged commit 93306e3 into main Jun 21, 2024
3 checks passed
@antfu antfu deleted the fix/ci-relax-nuxt branch June 21, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants