Skip to content

fix: throw error if non-POJO is an error #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

naquiroz
Copy link

@naquiroz naquiroz commented Feb 18, 2022

This pull request gives a better UX to a developer using nuxt. Right now, if an error is thrown and that cannot be stringified, the only thing shown is the error name —for example: TypeError—. With these changes, if the thing that is being stringified is an error, instead of just showing the name, the error is re-thrown, with an extended error message.

@naquiroz
Copy link
Author

Hey, is there any chance we can merge this pull request? 😄

@FredKSchott
Copy link

FredKSchott commented May 5, 2022

+1, we just ran into this issue in Astro as well moving from serialize-javascript, which supports this behavior by default.

@wobsoriano
Copy link

+1

@TheAlexLichter
Copy link
Member

cc @pi0

@naquiroz
Copy link
Author

naquiroz commented Feb 6, 2023

Can this be merged? It's been almost a year now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants