Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the original QuickSort to QuickSelect #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed the original QuickSort to QuickSelect #8

wants to merge 1 commit into from
+28 −26

Conversation

kak0na
Copy link

@kak0na kak0na commented Feb 22, 2025

Changed the original QuickSort to QuickSelect

@kak0na
Changed the original QuickSort to QuickSelect
afa0a77 
Changed the original QuickSort to QuickSelect
nutti
nutti reviewed Feb 22, 2025
View reviewed changes
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kak0na

Thank you for creating a pull request :)
It seems a good addition to this plugin.

BTW, is there any evidence that this new algorithm is faster?
Please show me the performance comparison result when you run this plugin on Unreal Engine.

@nutti nutti linked an issue Feb 22, 2025 that may be closed by this pull request
Your Todo: NthElement #7
Open
@nutti nutti added the enhancement New feature or request label Feb 22, 2025
@kak0na
Copy link
Author

kak0na commented Feb 26, 2025

@nutti
I used 400,000 locations for testing.
The build time was improved from 0.82 seconds to 0.18 seconds.
You can also try it

nutti
nutti requested changes Mar 31, 2025
View reviewed changes
Copy link
Owner

@nutti nutti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kak0na

Sorry for the late response.
I confirmed this implementation is much faster than the current one.
Please check the comments before merging this PR.

Kdtree/Source/Kdtree/Private/KdtreeInternal.cpp
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this line.

Kdtree/Source/Kdtree/Private/KdtreeInternal.cpp
while (true)
{
while (Left <= Last && Comparator(*Left, Pivot) == 1)
T* Pivot = First;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that using median is better choice instead of first element.
How do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutti nutti

Requested changes must be addressed to merge this pull request.

Assignees

@kak0na kak0na

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Your Todo: NthElement
2 participants
@kak0na @nutti