Docker support & fix terraform template #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AMI link in README.md for Master Branch
V2 final merge
Updated Axios to resolve a known vulnerability issue with versions <0.20.1.
Bumps [axios](https://github.com/axios/axios) from 0.18.1 to 0.21.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.21.1/CHANGELOG.md) - [Commits](axios/axios@v0.18.1...v0.21.1) Signed-off-by: dependabot[bot] <[email protected]>
…m-selfhost/compute-node/axios-0.21.1' into dev Capturing awhitehatter's force-merge to Master
Pull upstream
Fixed wiki reference
📌 Pin AWSCLI to version 2 📌 Use `grep -c` for terraform dependency check The `-c` flag counts the number of matches. A bit cleaner than `wc -l`
Pin AWSCLI version and update dependency checks
Added a dockerfile that builds a docker image to use npk. This provides two benefits. 1. If CoalfireLabs decides to publish and maintain the npk image, then users can just run npk by using a single command line in docker. 2. If CoalfireLabs does not publish a docker image, users can still use this dockerfile to build the container themselves. This prevents everyone from dealing with multiple terraform, python, pip and node versions that do not quite work together. Pending to be done: - Add ARGs, ENVs or a startup script (á la MySQL) so that the container can setup the aws credential profile when running and does not need to be a manual process. - Add ARG, ENVs or a startup script (á la MySQL) so that the container can setup the /npk/terraform/npk-settings.json file and does not need to be a manual process. - After these are done, we can remove `nano` (or any text editor) being installed, making the image smaller and faster to create. This change also fixes the error in the `terraform/cognito_iam_roles.tf` template, which basically just had an extra comma. Fixes Coalfire-Research#49.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dockerfile that builds a docker image to use npk. This provides two benefits.
If CoalfireLabs decides to publish and maintain the npk image, then users can just run npk by using a single command line in docker.
If CoalfireLabs does not publish a docker image, users can still use this dockerfile to build the container themselves.
This prevents everyone from dealing with multiple terraform, python, pip and node versions that do not quite work together.
Pending to be done:
nano(or any text editor) being installed, making the image smaller and faster to create.This change also fixes the error in the
terraform/cognito_iam_roles.tftemplate, which basically just had an extra comma. Fixes Coalfire-Research#49.