Skip to content

[W5][T11-1]Yang Shizhe - #57

Open
Shizhe-NUS wants to merge 2 commits into
nusCS2113-AY1819S2:masterfrom
Shizhe-NUS:{W5}{T11-1}-Yang-Shizhe
Open

[W5][T11-1]Yang Shizhe#57
Shizhe-NUS wants to merge 2 commits into
nusCS2113-AY1819S2:masterfrom
Shizhe-NUS:{W5}{T11-1}-Yang-Shizhe

Conversation

@Shizhe-NUS

@Shizhe-NUS Shizhe-NUS commented Feb 12, 2019

Copy link
Copy Markdown

No description provided.

@nus-se-pr-bot

nus-se-pr-bot commented Feb 12, 2019

Copy link
Copy Markdown

Hi @Shizhe-NUS, your pull request title is invalid.

For PR sent to satisfy a learning outcome, the PR name should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-2] means Wednesday 2pm (14 hrs), Team 2).
E.g. If you are in tutorial W09 (i.e. Wednesday 9am), team 1, and is submitting a PR for LO W2.2b, the PR title would be [W2.2b][W09-1] James Yong. Note that your tutorial IDs are different from those shown in CORS/IVLE.

For team PR, the PR name should be in the format of [Team ID] Product Name (e.g. [T09-2] Contact List Pro).

Please follow the above format strictly and edit your title for reprocessing.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at nus-se-pr-bot and add a link to this PR.

@Shizhe-NUS Shizhe-NUS changed the title change [W5][T11-1]Yang Shizhe Feb 12, 2019
@nus-se-pr-bot
nus-se-pr-bot requested a review from okkhoy February 12, 2019 02:59
Sameow
Sameow reviewed Feb 12, 2019
View reviewed changes

@Sameow Sameow left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi

Comment thread src/seedu/addressbook/data/person/Address.java
return isPrivate;
}

public static void comparedAddressBook(Address address){

@Sameow Sameow Feb 12, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice function. Pls teach me how to code. Thank you.

stephlewyh
stephlewyh reviewed Feb 17, 2019
View reviewed changes

@stephlewyh stephlewyh left a comment •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Shizhe,

Please review what is required for a new enhancement. You may close the PR after reading.

Comment thread src/seedu/addressbook/commands/AddCommand.java
}
}

public static void get(){

@stephlewyh stephlewyh Feb 17, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this function do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephlewyh stephlewyh stephlewyh left review comments
@okkhoy okkhoy Awaiting requested review from okkhoy
+1 more reviewer
@Sameow Sameow Sameow left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stephlewyh stephlewyh

Labels

Reviewed team.1 tutorial.T11

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Shizhe-NUS @nus-se-pr-bot @stephlewyh @Sameow