[W5][T09-3]Rachel Lim - #53
Open
rachellim10 wants to merge 2 commits into
Open
Conversation
|
Would be good to have a test file to ensure output is as expected for new function |
stephlewyh
reviewed
Feb 17, 2019
stephlewyh
left a comment
stephlewyh
left a comment
There was a problem hiding this comment.
Hi Rachel,
Good job this time!
However, you could write unit tests to ensure that your program prints out the correct datetime format. Also you need to ensure that header comments are added to methods to inform the reader of its functionality.
| Format: `clear` | ||
|
|
||
| == Prints out current date and time : `clock` | ||
| Format: `clock` |
There was a problem hiding this comment.
What is the description for your feature? It is missing.
| + ": Prints date and time in format: day, date-month-year at hr:min:sec AM/PM timezone.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| public CommandResult execute() { | ||
| Date now = new Date(); | ||
| SimpleDateFormat dateFormatter = new SimpleDateFormat("E, dd-MM-yyyy 'at' hh:mm:ss a z"); | ||
| //System.out.println("Date & Time now: " + dateFormatter.format(now)); |
There was a problem hiding this comment.
This comment is not necessary for your program to run, nor does it improve readability of your code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added clock function that prints date and time