[W5][T09-2]Zhang Jingchen - #51
Open
jingchen-z wants to merge 1 commit into
Open
Conversation
|
Nice small implementation. Checking email for any malicious characters is a good idea. |
sanjukta99
reviewed
Feb 17, 2019
sanjukta99
left a comment
sanjukta99
left a comment
There was a problem hiding this comment.
Good effort! In the future please try to work on a more extensive enhancement so that you can learn more about SE through coding and practice. Please read the review and close this PR.
| || add: Adds a person to the address book. Contact details can be marked private by prepending 'p' to the prefix. | ||
| || Parameters: NAME [p]p/PHONE [p]e/EMAIL [p]a/ADDRESS [t/TAG]... | ||
| || Example: add John Doe p/98765432 e/johnd@gmail.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney | ||
| || =================================================== |
There was a problem hiding this comment.
Good that you have added multiple test cases!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check conditions on user input in terms of email and phone number.
Also updated the test file.