[W5][T08-4]Phan Duy Nhat Tan - #49
Open
tantantan277 wants to merge 4 commits into
Open
Conversation
|
Useful command to check the size of the address book. Commits are separated clearly with specific purpose. |
stephlewyh
reviewed
Feb 17, 2019
stephlewyh
left a comment
stephlewyh
left a comment
There was a problem hiding this comment.
Hi Phan,
Good first attempt, having updated the user guide and enhancement. Note that you could have provided unit test for each new enhancement and supply header comments for your enhancement.
| Views all details of the 1st person in the results of the `find` command. | ||
|
|
||
| == Show the number of person in the address book : `size` | ||
|
|
There was a problem hiding this comment.
What is the description for this feature? It is missing.
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": Show the size of the address book.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| /** | ||
| * Show the size of the address book | ||
| */ | ||
| public int size() {return allPersons.size();} |
There was a problem hiding this comment.
method call of size() should be put on a separate line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.