[W5] [T11-1] Windrich - #48
Open
windrichie wants to merge 3 commits into
Open
Conversation
… person into the addressbook and view all persons in the addressbook thereafter.
|
Good Job! |
stephlewyh
reviewed
Feb 17, 2019
stephlewyh
left a comment
stephlewyh
left a comment
There was a problem hiding this comment.
Hi Windrich,
Excellent job for a first attempt. Do note that you need to provide header comments for your enhancements and with non-trivial methods. Avoid leaving behind commented out code in your submission.
You have provided tests with edge cases. Good job!
| return toAdd; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| addressBook.addPerson(toAdd); | ||
| List<ReadOnlyPerson> allPersons = addressBook.getAllPersons().immutableListView(); | ||
| return new CommandResult(getMessageForPersonListShownSummary(allPersons), allPersons); | ||
| // return new CommandResult(String.format(MESSAGE_SUCCESS, toAdd)); |
There was a problem hiding this comment.
This is an unnecessary inline comment.
| } | ||
| } | ||
|
|
||
| private Command prepareAddList(String args) { |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code in new class command adapted from existing command (AddCommand and ListCommand).