[W5][T09-3] Yow Ren Jie - #46
Conversation
| private static final Set<String> EMPTY_STRING_SET = Collections.emptySet(); | ||
|
|
||
| @Test | ||
| @org.junit.jupiter.api.Test |
There was a problem hiding this comment.
@gautamrajulu how do you declare that a method is a test method?
There was a problem hiding this comment.
@ren jie why do you need a new junit framework for this enhancement?
There was a problem hiding this comment.
@arhjaye why do you need another junit test framework for your enhancement?
| public static final String MESSAGE_USAGE = COMMAND_WORD + ": prints goodbye message.\n" | ||
| + "Example: " + COMMAND_WORD; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods (in this case your enhancement functionality) should have java doc format header comments.
| import seedu.addressbook.commands.ListCommand; | ||
| import seedu.addressbook.commands.ViewAllCommand; | ||
| import seedu.addressbook.commands.ViewCommand; | ||
| import seedu.addressbook.commands.*; |
There was a problem hiding this comment.
Imported classes should always be listed explicitly. E.g. java.util.List and not java.util.*, which does not follow NUS Java coding standards.
|
|
||
| switch (commandWord) { | ||
|
|
||
| case GoodbyeCommand.COMMAND_WORD: |
| + "\n" + ViewAllCommand.MESSAGE_USAGE | ||
| + "\n" + HelpCommand.MESSAGE_USAGE | ||
| + "\n" + ExitCommand.MESSAGE_USAGE | ||
| + "\n" + GoodbyeCommand.MESSAGE_USAGE |
There was a problem hiding this comment.
Unnecessary indentation. Reduces code readability.
| private static final Set<String> EMPTY_STRING_SET = Collections.emptySet(); | ||
|
|
||
| @Test | ||
| @org.junit.jupiter.api.Test |
There was a problem hiding this comment.
@gautamrajulu how do you declare that a method is a test method?
|
|
||
| @Test | ||
| @org.junit.jupiter.api.Test | ||
| public void addCommand_invalidName_throwsException() { |
There was a problem hiding this comment.
Missing header comment. All non-trivial methods should have java doc format header comments.
| private static final Set<String> EMPTY_STRING_SET = Collections.emptySet(); | ||
|
|
||
| @Test | ||
| @org.junit.jupiter.api.Test |
There was a problem hiding this comment.
@ren jie why do you need a new junit framework for this enhancement?
| private static final Set<String> EMPTY_STRING_SET = Collections.emptySet(); | ||
|
|
||
| @Test | ||
| @org.junit.jupiter.api.Test |
There was a problem hiding this comment.
@arhjaye why do you need another junit test framework for your enhancement?
4 participants
No description provided.