[W5][T08-01]-ZhaoJunRu - #44
Open
quinnzzzzz wants to merge 2 commits into
Open
Conversation
quinnzzzzz
changed the title
|
Interesting enhancement, the confirmation is widely used and very relevant to this |
|
Definitely a useful safeguard for newer users who accidentally type in the command |
RubaP
reviewed
Feb 13, 2019
RubaP
left a comment
RubaP
left a comment
There was a problem hiding this comment.
Good job for adding a simple but a nice enhancement. I would suggest to always update/add the test cases as well as a practice whenever you make a functional change.
| Warning message for clearing all data | ||
| Key in "YES" to continue | ||
| Clears all entries from the address book. + | ||
| Any key to exit clear function |
There was a problem hiding this comment.
Good that you have updated the UserGuide
| public CommandResult execute() { | ||
| addressBook.clear(); | ||
| return new CommandResult(MESSAGE_SUCCESS); | ||
| System.out.println("Confirm to clear the entire address book? YES to continue"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.