[W5][T09-2]Wan Chunwei - #35
Open
Wanchunwei wants to merge 5 commits into
Open
Conversation
|
A simple but useful feature. We can improve it into sorting by date. Then it can be used in our project. |
|
it's very thoughtful to add the message for invalid command. |
sanjukta99
reviewed
Feb 17, 2019
sanjukta99
left a comment
sanjukta99
left a comment
There was a problem hiding this comment.
Good job! Please remember to update the User Guide to reflect the new command that you have created. Please read the reviews and close this PR.
| import seedu.addressbook.data.person.UniquePersonList.DuplicatePersonException; | ||
|
|
||
| public class SortCommand extends Command{ | ||
| public static final String COMMAND_WORD = "Sort"; |
There was a problem hiding this comment.
You could add a header comment that explains what the Sort Command does to the user.
| add Charlie Dickson pp/333333 e/charlie.d@nus.edu.sg a/333, gamma street t/friends t/school | ||
| list | ||
| sort | ||
|
|
There was a problem hiding this comment.
Good job on updating the test cases!
| return 1; | ||
| } | ||
| else if(this.fullName.compareTo(o.fullName) < 0) { | ||
| return -1; |
There was a problem hiding this comment.
Please follow the Java Coding Standards which can be found on the module website for the correct format for if-else statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a sort command to sort all people by their name.