[W5][M11-2]Lew Sheng Kok - #29
Conversation
Shengkok
commented
Feb 10, 2019
Shengkok
commented
- Supports writing and saving notes.
- Supports viewing of saved notes.
| /** Version info of the program. */ | ||
| public static final String VERSION = "AddressBook Level 2 - Version 1.0"; | ||
|
|
||
| private static String[] NOTE; |
There was a problem hiding this comment.
Should probably have Notes as its own class instead of being in Main.
There was a problem hiding this comment.
Agreed. A proper design would require Note to be a class which associates itself to a Person.
devamanyu
left a comment
devamanyu
left a comment
There was a problem hiding this comment.
PR attempts to add the functionality of notes in AB.
Changes in the design to adhere to SE principles suggested. Kindly look at the comments and close this PR.
Also try to work on updating test cases 👍
| && this.allPersons.equals(((AddressBook) other).allPersons)); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Probably these whitespaces are not needed.
| /** Version info of the program. */ | ||
| public static final String VERSION = "AddressBook Level 2 - Version 1.0"; | ||
|
|
||
| private static String[] NOTE; |
There was a problem hiding this comment.
Agreed. A proper design would require Note to be a class which associates itself to a Person.
| for(String str: result){ | ||
| System.out.println(str); | ||
| } | ||
|
|
There was a problem hiding this comment.
Kindly note that this method "notes" is failing SE principles. Ways to improve would include following SLAP and SRP (printing, input, etc. all happening at the same place right now).
4 participants
