-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T13-5] Workoutbook #89
base: master
Are you sure you want to change the base?
[T13-5] Workoutbook #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a nice effort on the documentation. Its heartening to see that UML diagrams were attempted for each feature.
I have provided some comments, do give a look.
docs/DeveloperGuide.adoc
Outdated
@@ -1,4 +1,4 @@ | |||
= AddressBook Level 4 - Developer Guide | |||
= Workout Book - Developer Guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider changing the team name and dates to reflect your team
docs/DeveloperGuide.adoc
Outdated
|
||
==== Aspect: How recommend executes | ||
|
||
* **Alternative 1 (current choice):** Filters the workout list based on user's input and randomly generates a workout from that filtered list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the recommended workout "retrieved" randomly or "generated" randomly? Specify this to remove confusion.
docs/DeveloperGuide.adoc
Outdated
|
||
[[fig-ProfileCommand]] | ||
.Interactions inside `Logic` component for the *`profile`* command | ||
image::ProfileCommand.PNG[width="800"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused about some of the events in this sequence diagram. 1) If showProfileRequestEvent() is shown to create an "Events" object, then shouldn't there be a constructor. 2) Some of the processes seem to be working in "parallel", e.g. CommandResult is invoked before control returns from "Events". This may not be true as the code that you are working with are working sequentially. Do give a look into it. Please ignore, if I understood wrongly.
docs/DeveloperGuide.adoc
Outdated
|
||
// tag::trackfeature[] | ||
=== Tracking Feature | ||
==== Current Implementation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section seems to be incomplete. Please consider completing it.
docs/AboutUs.adoc
Outdated
@@ -19,38 +17,47 @@ Role: Project Advisor | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove Prof. Damith's photo from this page.
build.gradle edit + attempt to fix Travis newline EOF issue
fix travis error
update PPP
Update PPP and refactor some codes
Update DeveloperGuide
Update Developer and User Guide
Update Developer Guide
Fix UserGuide and DeveloperGuide
FIx UserGuide
Fix Project Portfolio
Fix guides
Deleted for privacy concerns
No description provided.