Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T13-5] Workoutbook #89

Open
wants to merge 1,262 commits into
base: master
Choose a base branch
from
Open

[T13-5] Workoutbook #89

wants to merge 1,262 commits into from

Conversation

yicheng12
Copy link

No description provided.

Copy link

@devamanyu devamanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall a nice effort on the documentation. Its heartening to see that UML diagrams were attempted for each feature.

I have provided some comments, do give a look.

@@ -1,4 +1,4 @@
= AddressBook Level 4 - Developer Guide
= Workout Book - Developer Guide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider changing the team name and dates to reflect your team


==== Aspect: How recommend executes

* **Alternative 1 (current choice):** Filters the workout list based on user's input and randomly generates a workout from that filtered list.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the recommended workout "retrieved" randomly or "generated" randomly? Specify this to remove confusion.


[[fig-ProfileCommand]]
.Interactions inside `Logic` component for the *`profile`* command
image::ProfileCommand.PNG[width="800"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused about some of the events in this sequence diagram. 1) If showProfileRequestEvent() is shown to create an "Events" object, then shouldn't there be a constructor. 2) Some of the processes seem to be working in "parallel", e.g. CommandResult is invoked before control returns from "Events". This may not be true as the code that you are working with are working sequentially. Do give a look into it. Please ignore, if I understood wrongly.


// tag::trackfeature[]
=== Tracking Feature
==== Current Implementation

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section seems to be incomplete. Please consider completing it.

@@ -19,38 +17,47 @@ Role: Project Advisor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Prof. Damith's photo from this page.

auskure pushed a commit to auskure/main that referenced this pull request Nov 3, 2018
build.gradle edit + attempt to fix Travis newline EOF issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants