[W12-4] FrozenBook #35

LIU-TIANHANG · 2018-10-02T13:46:36Z

@bluein-green
@Lunastryke
@scottljw
V1.1 details
PasswordLogin
Morph to store ingredients

CT15

User Guide and Developer Guide are updated
About Us is updated with the team photos
README is updated to remove CS2113 specific information

AboutUs.adoc -> need to:

remove John Doe from AboutUs.adoc
decide on each member's role and responsibilities

P.S. I think last time I saw more use cases and user stories. Can add them into DeveloperGuide.adoc as well.

Good job 👍
You can close this PR

CT15 · 2018-10-21T04:13:19Z

@LIU-TIANHANG @bluein-green @Lunastryke @scottljw

Review on v1.2:

Xuan Hao and Tianhang's photos are not showing in the project list. You may want to clarify this by sending e-mail to the module's email address if you think you have set up everything correctly.
Members' roles and responsibilities in About Us are not yet updated.
Under the login/logout feature implementation, you may want to check whether you are using the correct arrow to indicate association. If you are using some UML diagramming tools with different notations, it will be good to include a note to mention how the diagram differs from the standard notation.
Also under the login/logout feature implementation, initAddressBook does not look and sound like a class name.
The sequence diagram under the login/logout feature has some mistakes. Arrow pointing to an activation bar should exactly points to the start of the activation bar. You may also want to revisit how self-invocation and optional path are represented in sequence diagrams. Again, I am not sure whether this is because of the UML diagramming tools that is used. In this case, you should include a note to mention how it differs from the standard notation.
For the implementation of Analyses of profits and quantities sold in the company, UML diagram can be added to make your explanation clearer. Also, I think some bullet points are not rendered properly.
Generally, it will be good for each member of the team to use UML diagrams to better explain how a feature is implemented (one per head at least). Using code snippet is good but should be minimal because code becomes outdated very quickly.
I encourage other members to start including and explaining their enhancement under the Implementation section.

…cted amount

# Conflicts: # loginInfoManager.json

Morphing main UI pane to display Drink details

…into uiMorph

…into transactionV1

* update on test and welcome message * change login page * added event call to change logic * fixed the bug regarding mutiplle subsribe of event after login logout * remove debug sentence * change command into their respective model asd * EOF * update ppp ug dg * update on logout login bug * Update loginInfoManager.json * update on the ug dg bug * Update docs/team/tianhang.adoc * update on bottom list confirmation message and "import" to sell command * let coder choose to have confirmation or not * move help window from docs to help this help developer as they can pull form github as /docs are auto generated by grandle * new line eof * last minute check * Added newline at EOF * added some test need to fix a bug of login window (realted to empty username and password0 * UG: fix #134 * AnalysisManager: reduce code redundancies * analyseProfit and analyseRevenue (for all transactions) added * AnalysisPeriodType added * Modified Analysis to account for period * added more test * Date: added methods to return date 6 and 29 days before. created predicates to test for transaction within previous 7 and 30 days * used Predicates to filter transactions for analysis of costs * added TransactionList test * checkstyle for TransactionList * applay SLAP * changed * change test location * travis * travis EOF * travis please go alive * travis go heaven pls * travis go fly pls * added * move add and delete to manager * settle command * travis * change in ppp as make changes in UG /DG * changes to ppp * added * fix about us pic not showing * Update docs/AboutUs.adoc * update on UG * EOF * clean code * Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java * Revert "clean code" This reverts commit 717c9bd. * Revert "Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java" This reverts commit d39bf0f. * added * Revert "Revert "clean code"" This reverts commit ce7b3d4. * added * eof * Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java * update on test * add test * eof i love u..... * added more test to increase coverage * delete manager UG * update on uf * create a new interface for loginINformanager * Update src/main/java/seedu/address/init/InventoryListInitializer.java * same * add interface of LoginINfoManager * checkstyle * changed to fix logout login bug * Update loginInfoList.json * change on the header of UG * added roles * update on roles * Update docs/team/johndoe.adoc * Update README.adoc * update dg * EOF * delete john and add html page * eof * eof fly pls * eof * pppp * cec

MJ's PPP and DG parts

* update on test and welcome message * change login page * added event call to change logic * fixed the bug regarding mutiplle subsribe of event after login logout * remove debug sentence * change command into their respective model asd * EOF * update ppp ug dg * update on logout login bug * Update loginInfoManager.json * update on the ug dg bug * Update docs/team/tianhang.adoc * update on bottom list confirmation message and "import" to sell command * let coder choose to have confirmation or not * move help window from docs to help this help developer as they can pull form github as /docs are auto generated by grandle * new line eof * last minute check * Added newline at EOF * added some test need to fix a bug of login window (realted to empty username and password0 * UG: fix #134 * AnalysisManager: reduce code redundancies * analyseProfit and analyseRevenue (for all transactions) added * AnalysisPeriodType added * Modified Analysis to account for period * added more test * Date: added methods to return date 6 and 29 days before. created predicates to test for transaction within previous 7 and 30 days * used Predicates to filter transactions for analysis of costs * added TransactionList test * checkstyle for TransactionList * applay SLAP * changed * change test location * travis * travis EOF * travis please go alive * travis go heaven pls * travis go fly pls * added * move add and delete to manager * settle command * travis * change in ppp as make changes in UG /DG * changes to ppp * added * fix about us pic not showing * Update docs/AboutUs.adoc * update on UG * EOF * clean code * Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java * Revert "clean code" This reverts commit 717c9bd. * Revert "Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java" This reverts commit d39bf0f. * added * Revert "Revert "clean code"" This reverts commit ce7b3d4. * added * eof * Update src/test/seedu/address/logic/commands/AddDrinkCommandTest.java * update on test * add test * eof i love u..... * added more test to increase coverage * delete manager UG * update on uf * create a new interface for loginINformanager * Update src/main/java/seedu/address/init/InventoryListInitializer.java * same * add interface of LoginINfoManager * checkstyle * changed to fix logout login bug * Update loginInfoList.json * change on the header of UG * added roles * update on roles * Update docs/team/johndoe.adoc * Update README.adoc * update dg * EOF * delete john and add html page * eof * eof fly pls * eof * pppp * cec * pic * asd

* changes to DG testing * change asciidoctor.css

Updates to DG and PPP

update PPP

more test cases for manual testing

…n.git

Updates to PPP

Changed image sizes for PPP

Removed 1 sequence diagram to account for PPP Page limit

for XH, TH

* UG change * UG

added more manual test cases

Adding of author tags and updating reposense config

To conform to reposense dormat

nus-se-pr-bot added tutorial.W12 team.4 labels Oct 2, 2018

nus-se-pr-bot assigned CT15 Oct 2, 2018

nus-se-pr-bot requested a review from okkhoy October 2, 2018 13:47

CT15 approved these changes Oct 5, 2018

View reviewed changes

CT15 added v1.2-Reviewed v1.1-Reviewed labels Oct 21, 2018

bluein-green and others added 22 commits October 30, 2018 17:22

ImportDrinkCommand: added, linked to model

80b2eae

ImportDrinkCommand and Parser added

21db1bf

Add javadoc comments

4ed307d

ImportDrinkCommandParser: edited variable names

0c6d001

Analysis, AnalysisManager: added

9c7eaf8

Replaced DummySearchPage with an incomplete Drink page

dfcdb26

Fixed Import and Sell commands to be more LoD compliant + show transa…

26cefd7

…cted amount

Merge branch 'master' of https://github.com/Lunastryke/main.git

3425f4a

# Conflicts: # loginInfoManager.json

Misc things to fix nullPointerException

f40e7af

Merge branch 'master' of https://github.com/Lunastryke/main.git

fec6215

Edited updateBatchTransaction to take in Quantity object instead

5af37c9

Added newline at EOF

f55b441

Merge pull request #90 from Lunastryke/master

d314058

Morphing main UI pane to display Drink details

AnalyseCosts command and functionality added

81a87ba

loginInfoManager EOF

8a699b4

Merge branch 'master' of https://github.com/CS2113-AY1819S1-W12-4/main …

7c03ed2

…into uiMorph

use new Logic classes

e2a7f4f

fixed for checkstyle

696134f

WIP: drink card

ac4d1c2

edited for checkstyle

dd21201

edited MainWindow and DrinkCard

3c91ff6

Merge branch 'master' of https://github.com/CS2113-AY1819S1-W12-4/main …

96ca004

…into transactionV1

LIU-TIANHANG and others added 30 commits November 12, 2018 23:19

DG updates on analyses (#183)

d10e0e1

MJ's PPP and DG parts

Added images for DG

76f07c0

Merge branch 'master' into master

82d0511

Dgchange (#187)

4dd9216

* changes to DG testing * change asciidoctor.css

Merge pull request #185 from Lunastryke/master

ac67843

Updates to DG and PPP

update PPP

a228607

Merge pull request #189 from scottljw/master

345a0f5

update PPP

update PPP

8074613

Merge pull request #191 from scottljw/master

9321ade

update PPP

Updates to PPP

cc3ddce

Merge branch 'master' of https://github.com/Lunastryke/main.git

caa3bd6

add DG (#190)

7cbf957

more test cases for manual testing

Merge branch 'master' of https://github.com/CS2113-AY1819S1-W12-4/mai…

e8b01dd

…n.git

Merge pull request #192 from Lunastryke/master

f2f5226

Updates to PPP

Changed image sizes for PPP

9cfebac

Merge pull request #193 from Lunastryke/master

58ca586

Changed image sizes for PPP

Removed 1 sequence diagram to account for PPP Page limit

f931d97

Removed more diagrams

61c9bf8

Merge pull request #195 from Lunastryke/master

3d5f476

Removed 1 sequence diagram to account for PPP Page limit

edits to PPP, UG, DG (#194)

f873216

for XH, TH

UG change (#196)

e5551d3

Ug change (#197)

a54244e

* UG change * UG

added more manual test cases

41a9e4b

Merge pull request #198 from bluein-green/lastChangeToDG

8f3af6f

added more manual test cases

Adding of author tags and updating reposense config

4230653

Newline @ EOF

b526f6d

Merge pull request #200 from Lunastryke/master

6f7271b

Adding of author tags and updating reposense config

Rename reposense config.json.txt to config.json

36bb302

To conform to reposense dormat

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[W12-4] FrozenBook #35

[W12-4] FrozenBook #35

LIU-TIANHANG commented Oct 2, 2018

CT15 left a comment

CT15 commented Oct 21, 2018 •

edited

Loading

[W12-4] FrozenBook #35

Are you sure you want to change the base?

[W12-4] FrozenBook #35

Conversation

LIU-TIANHANG commented Oct 2, 2018

CT15 left a comment

Choose a reason for hiding this comment

CT15 commented Oct 21, 2018 • edited Loading

CT15 commented Oct 21, 2018 •

edited

Loading