[wahkia] iP by wahkia · Pull Request #99 · nus-cs2113-AY2425S1/ip

wahkia · 2024-09-03T06:06:22Z

No description provided.

This is the first entry of the project. It contains a Java program that outputs a simple chatbot greeting and farewell message.

This commit adds functionality for echoing user commands and exiting on 'bye'. The chatbot now features a customizable personality, with random fun responses for unknown commands and special handling for recognized commands like 'list'.

This update enables Lia to store tasks entered by the user and display them upon request with the 'list' command. The chatbot now also acknowledges each added task and continues to offer a personalized farewell when 'bye' is entered.

This commit introduces the ability to mark tasks as done or not done using the 'mark' and 'unmark' commands. A new Task class has been added to represent tasks, encapsulating the task description and status. The 'list' command now shows the status of each task.

This commit refactors both the chatbot and Task class to comply with Java coding standards. Javadoc comments have been added for all methods and classes. The code layout, including indentation, brace placement, and line length, has been adjusted.

This commit introduces three types of tasks—ToDo, Deadline, and Event— to the Lia chatbot. Users can now add tasks with or without specific dates and times. The tasks are displayed with their respective types and details when listed. The code has been refactored to handle these task types using inheritance, with each type represented by its own class.

Changed input.txt and updated the output with the expected results in EXPECTED.TXT.

This commit refactors the Duke chatbot by extracting the repetitive task addition and confirmation printing logic into a new method `addTaskAndPrint()`. This change improves code maintainability and readability by reducing redundancy in handling "todo", "deadline", and "event" commands.

kennethSty

Your code is well-structured and functional. I’ve added a few comments about coding standards and quality improvements. Specifically, I suggest:

Indentation: Instead of manually inserting whitespace for formatting, consider defining an INDENTATION constant to maintain consistency and readability across your code.

Error Handling: To enhance system stability, especially when dealing with potential user input errors, consider wrapping your return values in an Optional object. This will provide a safer way to handle nulls and unexpected inputs.

kennethSty · 2024-09-04T04:44:09Z

+
+    public static void main(String[] args) {
+        // Customizing the chatbot with the name Lia
+        String logo =


Coding Standard: Logo is constant. Use LOGO

kennethSty · 2024-09-04T04:45:26Z

+        System.out.println("    Hello! I'm \n" + logo);
+        System.out.println("    What can I do for you?");


Instead of leaving whitespaces use a constant String with the amount of whitespace and add them as INCIDENTION. This way UI bugs of not using enough whitespace can be avoided.

kennethSty · 2024-09-04T04:51:50Z

+class ToDo extends Task {
+
+    /**
+     * Creates a new ToDo task with the given description.
+     *
+     * @param description A description of the ToDo task.
+     */
+    public ToDo(String description) {
+        super(description);
+    }
+
+    /**
+     * Returns a string representation of the ToDo task.
+     *
+     * @return A string representing the ToDo task.
+     */
+    @Override
+    public String toString() {
+        return "[T]" + super.toString();
+    }
+}
+
+/**
+ * Represents a Deadline task, which is a task that needs to be done
+ * before a specific date/time.
+ */
+class Deadline extends Task {
+    protected String by;
+
+    /**
+     * Creates a new Deadline task with the given description and deadline.
+     *
+     * @param description A description of the task.
+     * @param by The deadline by which the task must be completed.
+     */
+    public Deadline(String description, String by) {
+        super(description);
+        this.by = by;
+    }
+
+    /**
+     * Returns a string representation of the Deadline task.
+     *
+     * @return A string representing the Deadline task.
+     */
+    @Override
+    public String toString() {
+        return "[D]" + super.toString() + " (by: " + by + ")";
+    }
+}
+
+/**
+ * Represents an Event task, which is a task that starts and ends
+ * at specific dates/times.
+ */
+class Event extends Task {
+    protected String start;
+    protected String end;
+
+    /**
+     * Creates a new Event task with the given description, start, and end times.
+     *
+     * @param description A description of the event.
+     * @param start The start time of the event.
+     * @param end The end time of the event.
+     */
+    public Event(String description, String start, String end) {
+        super(description);
+        this.start = start;
+        this.end = end;
+    }
+
+    /**
+     * Returns a string representation of the Event task.
+     *


Consider creating new files for each class.

kennethSty · 2024-09-04T04:53:09Z

+list
+deadline return book /by Sunday
+list
+event project meeting /from Mon 2pm /to 4pm


consider adding "wrong user input" to test whether the application breaks if e.g. deadline is used without /by.

kennethSty · 2024-09-04T04:54:05Z

+        printLine();
+        System.out.println(" Got it. I've added this task:");
+        System.out.println("   " + task.toString());
+        System.out.println(" Now you have " + taskCount + " tasks in the list.");


Well done. The feedback to the user is helpful.

This commit introduces the following changes to comply with Java coding standards: - Added a constant 'INDENTATION' for consistent indentation in output. - Updated the 'LOGO' variable to uppercase as a constant. - Refactored the code layout for improved readability and maintainability.

This commit restructures the Task class into three specific subclasses. This change improves code organization and provides clearer modeling of different task types.

Defined a class LiaException to represent exceptions specific to Lia.

This commit introduces custom error handling for the Lia chatbot using a LiaException class. Errors such as missing descriptions for todo tasks and invalid input for deadlines and events are now handled with user-friendly error messages. Unrecognized commands also trigger an error response.

This commit ensures that the task class and its subclasses can be packaged in the future.

This commit organizes the code into two packages: - `task` package for task-related classes: Task, ToDo, Deadline, Event. - `exception` package for Lia-specific exceptions: LiaException. This improves code modularity and structure, making it easier to maintain and extend.

This commit refines how taskCount is handled in the Lia chatbot. Previously, taskCount was incremented globally after each command, leading to incorrect task counts for non-task-adding commands like 'list'. Now, taskCount is only incremented when tasks are actually added ('todo', 'deadline', 'event'), preventing issues like NullPointerExceptions during subsequent list commands.

This commit updates support for marking and unmarking tasks in the Lia chatbot with error handling.

This commit replaces the static Task[] array with an ArrayList<Task> to dynamically handle task creation and management. This change enhances flexibility in task operations like adding, listing, and marking tasks, and ensures scalability without the limitations of a fixed-size array.

This commit introduces support for deleting tasks from the task list. Users can now enter 'delete <task number>' to remove a specific task. The remaining tasks are updated, and the user is notified of the task removal and the current number of tasks.

This commit introduces file persistence to the Lia chatbot, enabling tasks to be saved to and loaded from a file (./data/lia.txt). Tasks are automatically saved whenever the task list is modified and loaded at startup. The system also handles missing files or directories.

This commit enhances the Lia chatbot's ability to handle corrupted or invalid data in the task file. The system now detects wrong task entries, skips them, and prints warnings while continuing to load valid tasks from the file.

# Conflicts: # src/main/java/Lia.java

okkhoy

There are quite a few opportunities to eliminate arrow-head code. Try to use guard clauses to remove these.

okkhoy · 2024-09-26T15:24:36Z

+
+    public static void main(String[] args) {
+        // Customizing the chatbot with the name Lia
+        String LOGO =


make it constant?

okkhoy · 2024-09-26T15:48:11Z

+        String input;
+        ArrayList<Task> tasks = loadTasks();  // Load tasks from file
+
+        // Greet the user with enthusiasm


this looks like a note-to-self comment or a redundant comment; can be removed

okkhoy · 2024-09-26T15:48:31Z

+                saveTasks(tasks);
+
+            } catch (LiaException e) {
+                // Handle any Lia-specific exceptions


misleading comment since you are not doing anything specific apart from printing the message.

okkhoy · 2024-09-26T15:49:27Z

+        Path filePath = Paths.get(FILE_PATH);
+
+        try {
+            if (!Files.exists(filePath)) {


make this as a guard clause;
eliminate the following arrow-head code

- Extracted Ui, Storage, Parser, and TaskList classes for better organization. - Implemented Command pattern with specific command classes (AddCommand, DeleteCommand, etc.). - Enhanced maintainability and readability of the codebase.

Updated load method to parse dates using LocalDateTime. Added a parseDateTime method for converting date strings to LocalDateTime objects. Modified save method to ensure task dates are stored in the new format. Ensured proper error handling for invalid date formats during loading.

Enhance chatBot to support date and time handling

Added FindCommand class to handle task searching. Updated Parser class to recognize the find command. Integrated find functionality into the existing command execution flow. Enhanced UI to display matching tasks to the user.

Implement find command to search for tasks by keyword

Add Javadoc comments for improved code documentation

Add User Guide for Lia chatbot with usage instructions and features

…roved user engagement

wahkia added 9 commits August 27, 2024 22:13

Add initial chatbot greeting and farewell code

ee93d49

This is the first entry of the project. It contains a Java program that outputs a simple chatbot greeting and farewell message.

Add task storage and listing functionality to Lia

83b1a8f

This update enables Lia to store tasks entered by the user and display them upon request with the 'list' command. The chatbot now also acknowledges each added task and continues to offer a personalized farewell when 'bye' is entered.

Add more print line indents to better align ouput

a2c539f

Refactor I/O redirection testing setup for Duke

efc785b

Changed input.txt and updated the output with the expected results in EXPECTED.TXT.

kennethSty reviewed Sep 4, 2024

View reviewed changes

wahkia added 16 commits September 9, 2024 16:00

Refactor Task class into separate ToDo, Deadline, and Event subclasses

8419b12

This commit restructures the Task class into three specific subclasses. This change improves code organization and provides clearer modeling of different task types.

Add a new class called LiaException

3c59eab

Defined a class LiaException to represent exceptions specific to Lia.

Merge branch 'branch-level-5'

84d3c01

Refactor Task class to include ToDo, Deadline, and Event subclasses

cb198a4

This commit ensures that the task class and its subclasses can be packaged in the future.

Merge branch 'branch-A-Packages'

4ae1e71

Reimplement task marking and unmarking functionality

3db5cdc

This commit updates support for marking and unmarking tasks in the Lia chatbot with error handling.

Add delete function to Lia chatbot

cd4443e

This commit introduces support for deleting tasks from the task list. Users can now enter 'delete <task number>' to remove a specific task. The remaining tasks are updated, and the user is notified of the task removal and the current number of tasks.

Add error handling for corrupted data in file loading

35e1c12

This commit enhances the Lia chatbot's ability to handle corrupted or invalid data in the task file. The system now detects wrong task entries, skips them, and prints warnings while continuing to load valid tasks from the file.

Merge branch 'branch-Level-6'

708a2ba

Merge branch 'branch-Level-7'

3f2fa4e

# Conflicts: # src/main/java/Lia.java

okkhoy reviewed Sep 26, 2024

View reviewed changes

wahkia and others added 3 commits October 10, 2024 18:03

Refactor code to improve OOP structure

05cb2bb

- Extracted Ui, Storage, Parser, and TaskList classes for better organization. - Implemented Command pattern with specific command classes (AddCommand, DeleteCommand, etc.). - Enhanced maintainability and readability of the codebase.

Merge pull request #1 from wahkia/branch-level-8

6ad1da8

Enhance chatBot to support date and time handling

wahkia and others added 11 commits October 10, 2024 19:07

Implement find command to search for tasks by keyword

d8d77a6

Added FindCommand class to handle task searching. Updated Parser class to recognize the find command. Integrated find functionality into the existing command execution flow. Enhanced UI to display matching tasks to the user.

Merge pull request #2 from wahkia/branch-Level-9

a191c7e

Implement find command to search for tasks by keyword

Add Javadoc comments tfor improved code documentation

46f1638

Merge pull request #3 from wahkia/branch-A-JavaDoc

0af4ce4

Add Javadoc comments for improved code documentation

Add User Guide for Lia chatbot with usage instructions and features

145a188

Merge pull request #4 from wahkia/branch-A-UserGuide

a06ac05

Add User Guide for Lia chatbot with usage instructions and features

Update on the style and design of the user guie

12da9a8

Enhance Lia's personality in chatbot responses and add emojis for imp…

b94104e

…roved user engagement

Upadate lia chatBot to not include emojis

bb6f4f5

Add getting started section to the user guide

362dd99

Refactor the run command for Lia.jar

636a76e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wahkia] iP#99

[wahkia] iP#99
wahkia wants to merge 39 commits into
nus-cs2113-AY2425S1:masterfrom
wahkia:master

wahkia commented Sep 3, 2024

Uh oh!

kennethSty left a comment

Uh oh!

kennethSty Sep 4, 2024

Uh oh!

kennethSty Sep 4, 2024

Uh oh!

kennethSty Sep 4, 2024

Uh oh!

kennethSty Sep 4, 2024

Uh oh!

kennethSty Sep 4, 2024

Uh oh!

okkhoy left a comment

Uh oh!

okkhoy Sep 26, 2024

Uh oh!

okkhoy Sep 26, 2024

Uh oh!

okkhoy Sep 26, 2024

Uh oh!

okkhoy Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		System.out.println(" Hello! I'm \n" + logo);
		System.out.println(" What can I do for you?");

Conversation

wahkia commented Sep 3, 2024

Uh oh!

kennethSty left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

okkhoy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants