[Qin Kai] iP by kq2003 · Pull Request #98 · nus-cs2113-AY2425S1/ip

kq2003 · 2024-09-03T05:39:43Z

I am a person.

AdiMangalam

Overall good. Can improve on coding standards like have better variable names, split into different methods, have different files etc.

AdiMangalam · 2024-09-05T02:33:02Z

+
 public class bro {
+
+    private static ArrayList<String> storer = new ArrayList<>();


Can have a better variable name. Maybe specify what 'storer' stores.

AdiMangalam · 2024-09-05T02:39:23Z

+    public static void level0() {
+        System.out.println("Hello! I'm bro");
+        System.out.println("What can I do for you?");
+        System.out.println("Bye. Hope to see you again soon!");


This line should not be here? The chatbot prints Bye almost instantly

Bye should not be in level 0

AdiMangalam · 2024-09-05T02:41:24Z

+                System.out.println("Nice! I've marked this task as done:");
+                System.out.println("[X] " + storer.get(task_num));
+
+            } else if (split_line[0].equals("unmark")) {


Should have made 'unmark' as another method. That way it is easier to debug/make changes.

AdiMangalam · 2024-09-05T02:45:46Z

+            System.out.println(line);
+        }
+
+        System.out.println("Bye. Hope to see you again soon!");


This line is redundant. Needs to be displayed only when 'bye' is entered by user.

AdiMangalam

Overall good. Can have better coding standards.

AdiMangalam · 2024-09-05T02:50:23Z

+
+public class bro {
+
+    private static final ArrayList<String> storer = new ArrayList<>();


Have a better variable name. Can specify what 'storer' stores?

danusan-s

I have no idea what's going on here. Code does not even do what is expected from the increments. Lots of improvements can be made. Also remove redundant functions.

danusan-s · 2024-09-05T03:49:11Z

+        System.out.println("Bye. Hope to see you again soon!");
+    }
+
+    public static void echo() {


Did not remove redundant function that is no longer used.

danusan-s · 2024-09-05T03:49:48Z

+    private static final ArrayList<String> storer = new ArrayList<>();
+    private static final ArrayList<String> mark_tracker = new ArrayList<>();
+
+    public static void level0() {


Did bro hard code level 0 ? 😭 Did not remove redundant function again.

danusan-s · 2024-09-05T03:50:42Z

+public class bro {
+
+    private static final ArrayList<String> storer = new ArrayList<>();
+    private static final ArrayList<String> mark_tracker = new ArrayList<>();


Could have use a seperate class for Tasks to track the info and marking

danusan-s · 2024-09-05T03:54:36Z

+        String line;
+        Scanner in = new Scanner(System.in);
+
+        while (true) {


Wait if you have while(true) loop in your addList and you call your mark only after addList, wouldnt you be marking after the user inputs bye.

danusan-s · 2024-09-05T03:55:26Z

+        String line;
+        Scanner in = new Scanner(System.in);
+
+        while(true) {


Bro 😭, You can't add tasks once you are in marking mode ?

kq2003 · 2024-09-05T04:42:49Z

I have no idea what's going on here. Code does not even do what is expected from the increments. Lots of improvements can be made. Also remove redundant functions.

Agreed that I should put more time into it but the code does output what was needed for the first three levels. Just I haven't really cleaned the code yet but functionality is there. Also didn't upload part 4 yet; do you mind checking again once I updated my code.

thoriritu · 2024-09-23T16:40:59Z

+import java.util.ArrayList;
+import java.io.*;
+
+public class bro {


The class name bro should follow Java naming conventions. Use PascalCase for class names. Consider renaming it to something more descriptive, like TaskManager or TaskApp.

thoriritu · 2024-09-23T16:41:28Z

+
+    }
+
+    public static void addList() {


Use descriptive names for your methods. For example, addList could be renamed to manageTasks, as it implies that this method is responsible for task management

thoriritu · 2024-09-23T16:41:50Z

+        while (true) {
+            line = in.nextLine();
+
+            if (line.equals("Bye")) {


Avoid using magic strings directly in your code (e.g., "Bye", "list", "todo"). Instead, consider defining constants at the beginning of your class to improve readability and maintainability.

thoriritu · 2024-09-23T16:42:20Z

+                    saveTasks();
+                }
+
+            } else if (line.startsWith("deadline")) {


The sections handling different task types (Todo, Deadline, Event) have similar patterns for adding and saving tasks. Can create a helper method to reduce duplication

thoriritu · 2024-09-23T16:42:58Z

+                        storer.add(todo);
+                        break;
+                    case "D":
+                        Deadline ddl = new Deadline(parts[2], parts[3]);


Variables like ddl, taskInt, and task_num can be more descriptive. For instance, use deadlineTask instead of ddl, and taskIndex instead of taskInt. Consistency in naming conventions (camelCase) is also important

thoriritu · 2024-09-23T16:43:24Z

+
+    }
+
+    public static void addList() {


The addList method is quite long. Break it down into smaller methods for each task type handling to improve readability and maintainability.

…handled errors

kq2003 added 3 commits August 29, 2024 19:55

level-0

517cbb7

added level 1 2 3

1a784d3

coding standard

2585910

AdiMangalam reviewed Sep 5, 2024

View reviewed changes

danusan-s reviewed Sep 5, 2024

View reviewed changes

kq2003 added 9 commits September 6, 2024 15:51

level 4 increment: very rough and i will clean the code, but it works

1e3dbd6

improved code and functionality

94390c0

Implement error handling for event, todo, and deadline empty description

77151b3

Merge level 5

c6668cd

implemented branch level 6

03e144a

implemented level 7

8940ee6

Merge branch 'branch-level-6'

3dcb73b

conflict fixed

5046611

fixed

fe57d16

thoriritu reviewed Sep 23, 2024

View reviewed changes

kq2003 added 6 commits October 2, 2024 22:35

level 8 and level 9

f74f207

updated readme

72a5578

code cleaned for coding standard

79ca35c

java doc

0098143

completely changed the code structure and format, and fixed bugs and …

8216257

…handled errors

removed colons in javadoc comments

df24974


		public class bro {

		private static ArrayList<String> storer = new ArrayList<>();


		public class bro {

		private static final ArrayList<String> storer = new ArrayList<>();

Conversation

kq2003 commented Sep 3, 2024

Uh oh!

AdiMangalam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AdiMangalam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danusan-s left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kq2003 commented Sep 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants