[Low Beverly] iP#107
Conversation
…odified. Added some new features.
…odified. Added some new features.
TheDinos
left a comment
TheDinos
left a comment
There was a problem hiding this comment.
Overall, good job with minimal coding violations!
|
|
||
| String farewell = "All the best in clearing your list!"; | ||
|
|
||
| System.out.println(logo + charlie+ greeting); |
| if (index >= 0 && index < size) { | ||
| list[index].markTask(); | ||
| int remainingTask = countUnmarkedTasks(); | ||
| System.out.println(" Well Done! 1 task down, " + remainingTask + " to go."); |
There was a problem hiding this comment.
Perhaps the space identation could be made into a constant variable given its usage throughout the code.
| } | ||
|
|
||
| //To print list | ||
| public void toPrintList() { |
There was a problem hiding this comment.
Maybe the function name could be clearer without using "to"?
| } else if (line.startsWith("mark ")) { | ||
| //trim to get the task name | ||
| String taskDescription = line.substring(5).trim(); | ||
| boolean found = false; |
There was a problem hiding this comment.
Perhaps the boolean variable could be named "isFound" for greater clarity?
| } else if (line.startsWith("mark ")) { | ||
| //trim to get the task name | ||
| String taskDescription = line.substring(5).trim(); | ||
| boolean found = false; |
|
|
||
| //loop to find | ||
| for(int index = 0; index < toDo.size; index++) | ||
| { |
There was a problem hiding this comment.
Not following loop layout coding standard
There was a problem hiding this comment.
Sorry I dont understand what you mean, is this not the standard?
There are curly brackets, can I clarfiy what fo you mean
|
|
||
| //loop to find | ||
| for(int index = 0; index < toDo.size; index++) | ||
| { |
There was a problem hiding this comment.
Again, not following the loop layout coding standard
| //LIST CLASS | ||
| public static class List { | ||
| //make a list of task | ||
| private Task[] list; |
There was a problem hiding this comment.
Could name the array something in plural, like tasks
Add Level-8
Branch level 9
A java doc
4 participants
No description provided.