-
Notifications
You must be signed in to change notification settings - Fork 229
[CS2113-W14-3] Future Academic Planner (FAP) #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 250 commits
9ffc19e
5f0a3ac
97fbfa5
653c04b
9be9c6e
308093c
d9497e1
af0103e
79b82b0
a6ea25c
5e9be1d
ba3683e
d785e85
a821e6b
7e2e3e9
75d8c8a
c288ffa
e8b2929
38848c6
e7a5a5f
67b59db
32e62d1
a0ae09a
7c4a243
72f86d0
f160cea
fc3051e
45814c1
9f5b714
ecba2b6
7244f1a
295650d
bc87956
34f56ed
00165b8
488157f
a56f732
18cf27a
3db2cb5
4bb6bae
6ae1411
eb29a53
b71ace1
20e2da2
79460a5
ff0b2e9
f7a06ba
f9ff4de
5480127
1765467
e8f9ecd
2e3e5c3
196f565
2537764
be00586
da21753
860025d
8e6998f
b03fa64
32f22ac
ee36270
aec2bae
f78b5ca
216cace
d7b0556
4464a03
3c0aa61
a9a1eb1
e3d8ff6
404dd88
217b3dc
adacf62
8c5fafb
465814b
a98dbe1
6695f06
2e761de
edd17e1
f9a52e1
9c7b1fd
bd39a71
267dddf
8747af9
5dc6f4c
5fc7c27
7ffc03a
94bc0d0
bc4868c
aa527cf
4b6a7ac
8cfcbeb
9c28402
d05bdab
46cf896
f1100fe
542c506
b649869
1f0e22c
cfc1b65
2019bff
69abad7
5329a16
889689d
8badd57
17d1c64
29125f5
56a4a42
db6c072
6612a87
654e8a8
9706787
6ff057a
2cffd2f
72c0af6
e4f93e0
4e59852
12a6586
2673291
e413871
7d4444f
24e0c0d
0423e9f
3f5cb2d
10053d7
ccab92e
ebd29b1
67bbca1
363927e
564cf8b
6b07c3a
cda87aa
a173899
9b452a8
8dfdc30
8c5277e
3a2ae3a
ddc3cfc
0e8e83d
a133b10
e80cbef
cf3d7de
1e04cdd
8af9969
da81b95
a354bc4
6006f32
c2549f8
a5502f3
933fd98
389f71b
5529492
a0c7376
654076f
b01e0e1
f6f23d1
a71a683
de7365b
74fb12b
336e817
ef61094
c6690b5
f3f2d1b
544230d
3aef44e
450c499
ce7ecf9
1e99d73
a858ec3
5b2a9fc
ae7a744
2500283
edba26e
19de4f7
a3d0de1
febdfc0
4cc947f
958085a
3d76054
3f7ec91
b7e0f28
c7bd8bf
4dc0455
d7ae2e1
4977101
0f10064
091f735
68b16fb
7ef5f72
a5e653f
b41e251
713f786
ab59e64
974a9ba
ec3674c
9d2cbcf
916aa9b
350ea03
ee5a919
e199682
505aa9f
0617fb1
bcba761
087755e
8356aaa
136cfed
54b7410
7479351
8b61389
2221e89
70234e1
ddc2804
e720d91
05f265f
5d160a6
8c18f58
8566bb1
b8ba98a
3af88b6
225ff25
8c5f30a
6e17be0
ce86926
885c7ff
8f76eb9
32c4ff6
4d4ee94
db0e544
a7687a2
db32cc6
bbb54d9
40e0d9e
56bbcef
4c9c2f4
6255601
0786ae5
16ed65c
edb421c
9ba1e92
e3db77e
db49c09
9c97bd6
8c58dfb
4d1ba59
8e1e46b
f2b38f9
7012e25
4f744b7
628e965
4c4e6c3
88f42ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Manifest-Version: 1.0 | ||
| Main-Class: seedu.duke.FAP | ||
|
|
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| # About us | ||
|
|
||
| Display | Name | Github Profile | Portfolio | ||
| --------|:----:|:--------------:|:---------: | ||
|  | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
|  | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
|  | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
|  | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
|  | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md) | ||
| Display | Name | Github Profile | Portfolio | ||
| --------|:-------------:|:--------------:|:---------: | ||
| ![]() | John Doe | [Github](https://github.com/dextboy/) | [Portfolio]() | ||
|  | Foo Shi Xiang | [Github](https://github.com/sxfoo) | [Portfolio](docs/team/johndoe.md) | ||
|  | Fung Wen Wu | [Github](https://github.com/fungg0) | [Portfolio](docs/team/johndoe.md) | ||
|  | Dave Gunawan | [Github](https://github.com/jensonjenkins) | [Portfolio](docs/team/johndoe.md) | ||
|  | Thaw Tun Zan | [Github](https://github.com/ThawTunZan) | [Portfolio](docs/team/johndoe.md) |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GpaNullException should be created in the alt frame. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you shouldn't label the arrow for non-countable grade as continue iteration, it may be treated as a return value instead. A return arrow with no return value already indicates return of control. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the sequence diagram is overly simplified. There should be a function call getModuleGrade() from ModuleList to Module and a return value of type String back to ModuleList, followed by an alt frame that leaves the section for uncountable grade empty and an else section that calls getModuleMC() and getModuleGrade() There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should be a function call to log() of LOGGER, and no return value for the return function call |
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PlantUML user guide has instructions on how to change public private to + -