[yuhengr] ip by yuhengr · Pull Request #193 · nus-cs2113-AY2324S2/ip

yuhengr · 2024-02-09T08:02:59Z

No description provided.

webtjs

Nice work! Overall, the code follows the code quality guidelines. Naming of variables & methods are appropriate, and the code is readable with the exception of some long lines.

webtjs · 2024-02-09T15:55:00Z

+                int fromPosition = userInput.indexOf("/from");
+                int toPosition = userInput.indexOf("/to");
+
+                tasks[taskCount] = new Event(userInput.substring(dividerPosition + 1, fromPosition - 1), userInput.substring(fromPosition + 6, toPosition - 1), userInput.substring(toPosition + 4));


Maybe you can consider line wrapping? This line seems quite long.

webtjs · 2024-02-09T16:01:34Z

+            else if(words[0].equals("deadline")){
+                int dividerPosition = userInput.indexOf(" ");
+                int slashPosition = userInput.indexOf("/by");
+                tasks[taskCount] = new Deadline(userInput.substring(dividerPosition + 1, slashPosition - 1), userInput.substring(slashPosition + 4));


Maybe you can consider line wrapping for this line also?

webtjs · 2024-02-09T16:04:08Z

+
+        String userInput;
+        Scanner in = new Scanner(System.in);
+        Task[] tasks = new Task[100];


I like the use of plural form to indicate multiple tasks

webtjs · 2024-02-09T16:22:46Z

@@ -6,5 +8,72 @@ public static void main(String[] args) {
                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";


Should the logo variable be deleted since it's not used?

webtjs · 2024-02-09T16:31:25Z

+    public String getStatusIcon() {
+        return (isDone ? "X" : " ");
+    }
+
+    public void markAsDone() {
+        this.isDone = true;
+    }
+
+    public void markAsNotDone() {
+        this.isDone = false;
+    }


Method names are good as they sound like verbs

nichyjt

Hi Yu Heng,

Try to avoid using magic literals in your program, this is a code quality requirement!
Do consider refactoring some parts of your code that are very long. This will help in readability!

There are some other specific comments below. Try and fix them before the next tutorial!

For your consideration: There is a way to autoformat your code automatically every time you Ctrl-S on intellij which will save you much pain. :)

nichyjt · 2024-02-23T10:49:25Z

@@ -0,0 +1,14 @@
+public class Deadline extends Task{


Formatting error with the curly brace!

nichyjt · 2024-02-23T10:50:01Z

 public class Duke {
    public static void main(String[] args) {
+        /*
        String logo = " ____        _        \n"


Ditto with the comment by your peer. Remove code that is commented out!

nichyjt · 2024-02-23T10:50:16Z

+        String userInput;
+        Scanner in = new Scanner(System.in);
+        ArrayList<Task> tasks = new ArrayList<>();
+        // Task[] tasks = new Task[100];


Remove unused code, please.

nichyjt · 2024-02-23T10:52:33Z

+        while(!userInput.equals("bye")){
+            String[] userInputWords = userInput.split(" ");
+
+            if(userInput.equals("list")){


This if-else chain is nested and very long. This usually hints that there can be room for improvement for making your code SLAP more.

To aid you in achieving SLAP, here are some guiding questions...

What parts of the code is repetitive? i.e. virtually the same for each if/else block you have

What part of the code does a particular function that can be isolated into a function?

nichyjt · 2024-02-23T10:54:01Z

+                        int fromPosition = userInput.indexOf("/from");
+                        int toPosition = userInput.indexOf("/to");
+
+                        tasks.add(new Event(userInput.substring(dividerPosition + 1, fromPosition - 1), userInput.substring(fromPosition + 6, toPosition - 1), userInput.substring(toPosition + 4)));


This is pretty hard to read, especially with all the magic literals. Do refactor your magic literals. You can consider breaking this up into a function!

nichyjt · 2024-02-23T10:54:25Z

@@ -0,0 +1,15 @@
+public class Event extends Task{


Formatting error with the curly brace!

Add Level-9 in branch-Level-9

Add A-JavaDoc

yuhengr added 5 commits January 26, 2024 14:13

Add chatbot skeleton

cfe27b7

Add level 1

6db6312

Add level 2

efcec81

Add level 3

3440622

Add level 4

cec49c2

webtjs reviewed Feb 9, 2024

View reviewed changes

yuhengr added 12 commits February 23, 2024 03:52

Add level 5

55b6be6

Add level 5 in branch-Level-5

a23e514

Add error handling for mark and unmark

98de3d5

Rename variables

b04d05d

Change error messages for mark and unmark

43028d3

Merge branch 'branch-Level-5'

c504b93

Add skeleton for delete

894d758

Add delete feature

17b2bac

Add level 7 write to file

f28f0ce

Disable opening logo

eb7ebe6

Merge branch 'branch-Level-6'

0af291b

Add level 7 read from file

ab8d095

nichyjt reviewed Feb 23, 2024

View reviewed changes

yuhengr added 11 commits March 6, 2024 17:22

Merge branch-Level-7

1bb8666

Refactor read from file functionality to a method

2032036

Refactor to remove magic numbers

e46f8a7

Add storage package skeleton

68e709b

Refactor tasks-related classes to package

5a43cbc

Modify classes in package task

1e5b368

Import package task

ff6ffbf

Add imports for class Storage

accdf6f

Add class TaskList

b9139c0

Add addTodo method in class TaskList

616a5d4

Abstract commands into class TaskList

7622977

yuhengr and others added 21 commits March 7, 2024 17:50

Refactor file management into class Storage

5aa8ebe

Add package ui

3a67fa2

Add messages to class UI

dc65e62

Fix bug that appends additional ) when loading tasks

101a9a0

Refactor ui messages

86e95f3

Modify to handle both upper and lower cases

2e41c85

Add class Parser skeleton

6af42f4

Add parseTodo method to class Parser

400cc86

Add methods to parse Deadline and Event to class Parser

6738b93

Fix bug. Empty Todo description will now be caught.

6fd592c

Trim user input before adding to tasks

4c0e67f

Refactor error messages

a702714

Add Level-9 in branch-Level-9

b4baa94

Merge pull request #1 from yuhengr/branch-Level-9

449d6ca

Add Level-9 in branch-Level-9

Refactor code

ea0b2b4

Add A-JavaDoc

2b97a19

Merge pull request #2 from yuhengr/branch-A-JavaDoc

6152c52

Add A-JavaDoc

Add more comments

f7ab8bc

Add initial edit for A-UserGuide

0428822

Add more JavaDoc comments

ea631e8

Edit README.md

ff8bf1e

		@@ -6,5 +8,72 @@ public static void main(String[] args) {
		+ "\| \|_\| \| \|_\| \| < __/\n"
		+ "\|____/ \\__,_\|_\|\\_\\___\|\n";

Uh oh!

Conversation

yuhengr commented Feb 9, 2024

Uh oh!

webtjs left a comment

Choose a reason for hiding this comment

Uh oh!

webtjs Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webtjs Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

webtjs Feb 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nichyjt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

webtjs Feb 9, 2024 •

edited

Loading

webtjs Feb 9, 2024 •

edited

Loading

webtjs Feb 9, 2024 •

edited

Loading