[Praneet-25] iP#191
Open
Praneet-25 wants to merge 20 commits into
Open
Conversation
…y them back to the user when requested.
…s, add the ability to change the status back to not done.
okkhoy
reviewed
Mar 3, 2024
okkhoy
left a comment
okkhoy
left a comment
There was a problem hiding this comment.
Please remember to merge code to your master branch and push the code. The PR doesn't seem to have progressed in a long time.
I hope these review comments help in polishing the iP code before submission.
Comment on lines
+12
to
+14
| } | ||
|
|
||
| else { |
|
|
||
| static ArrayList<Task> listOfItems = new ArrayList<>(); | ||
|
|
||
| //variable stores the number of tasks being added |
| + "|____/ \\__,_|_|\\_\\___|\n"; | ||
| System.out.println("Hello from\n" + logo); | ||
|
|
||
|
|
There was a problem hiding this comment.
The main method is doing a lot of things. please follow the instructions in A-MoreOOP and refactor the code accordingly.
Comment on lines
+199
to
+206
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Comment on lines
+37
to
+44
| task = new Deadline(description); // Create Deadline task | ||
| break; | ||
| case "E": | ||
| task = new Event(description); // Create Event task | ||
| break; | ||
| case "T": | ||
| task = new ToDo(description); // Create Todo task | ||
| break; |
Add find functionality
# Conflicts: # src/main/java/Duke.java # src/main/java/Storage.java # src/main/java/TaskList.java # src/main/java/ToDo.java # src/main/java/Ui.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.