[vimalapugazhan] iP by vimalapugazhan · Pull Request #188 · nus-cs2113-AY2324S2/ip

vimalapugazhan · 2024-02-08T05:33:16Z

No description provided.

tayponghee · 2024-02-08T05:38:59Z

+                index = Integer.parseInt(userInput.substring(5)) - 1;
+                list[index].markAsDone();
+                System.out.println(LINE + TAB + "Nice! I've marked this task as done:\n" + TAB +
+                        "   [X] " + list[index].getDescription() +"\n" + LINE);


Missing a space between + and "\n"

tayponghee · 2024-02-08T05:40:02Z

+                return;
+            }
+
+            if (userInput.equals("list")) {


Consider refactoring the code to reduce the length in void main

tayponghee · 2024-02-08T05:48:10Z

+                continue;
+            }
+
+            else if (userInput.contains("mark")) {


else if should be placed on the same line as on 42

tayponghee · 2024-02-08T05:54:47Z

@@ -0,0 +1,58 @@
+import java.util.Scanner;


Import was explicitly listed

luozihui2003 · 2024-02-08T15:20:51Z

+            String userInput = in.nextLine();
+
+            if (userInput.equals("bye")) {
+                System.out.println(LINE + TAB + EXIT + LINE);


consider using multiple print statements to make the code more readable

luozihui2003 · 2024-02-08T15:22:50Z

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


ideal to refer to all instance parameters with the this keyword, e.g. this.isDone

luozihui2003 · 2024-02-08T15:24:12Z

+    }
+
+    public String getStatusIcon() {
+        return (isDone ? "X" : " "); // mark done task with X


good use of ternary statements, though brackets are not needed to evaluate them

luozihui2003 · 2024-02-08T15:26:05Z

+                "    What can I do for you?\n";
+        String EXIT = "    Bye. Hope to see you again soon!\n";
+        String TAB = "    ";
+        Task[] list = new Task[100];


can consider making the length of the task array a variable

… exceptions

sevenseasofbri

well done, i've pointed out a few things that can improve the readability and quality of your code. 👍🏽

sevenseasofbri · 2024-02-19T11:43:03Z

+
+import exceptions.AragornException;
+
+public class inputParser {


Class/enum names must be nouns and written in PascalCase. So in your case, it should be InputParser instead.

sevenseasofbri · 2024-02-19T11:43:47Z

+import exceptions.AragornException;
+
+public class inputParser {
+    private String[] splitInput = new String[3];


avoid using magic literals in the code, consider storing it in a constant (static final)

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#avoid-magic-numbers

sevenseasofbri · 2024-02-19T11:44:10Z

+    public inputParser(String userInput, String commandType) throws AragornException {
+        String[] splitDeadline;
+        String[] splitEvent;
+        String LINE =  "    __________________________________________________________\n";


good, but maybe this can be a constant at the class-level

sevenseasofbri · 2024-02-19T11:45:15Z

+public class inputParser {
+    private String[] splitInput = new String[3];
+
+    public inputParser(String userInput, String commandType) throws AragornException {


this function is quite long (30+ LOC). consider abstracting out the code into multiple functions

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#avoid-long-methods

sevenseasofbri · 2024-02-19T11:45:59Z

+            case "MARK":
+                this.splitInput[0] = String.valueOf(Integer.parseInt(userInput.substring(5).trim()) - 1);
+                this.splitInput[1] = null;
+                this.splitInput[2] = null;
+                break;
+
+            case "UNMARK":
+                this.splitInput[0] = String.valueOf(Integer.parseInt(userInput.substring(7).trim()) - 1);
+                this.splitInput[1] = null;
+                this.splitInput[2] = null;
+                break;
+
+            case "TODO":
+                try {
+                    this.splitInput[0] = userInput.substring(4);
+                    if (this.splitInput[0].trim().isEmpty()){
+                        throw new AragornException(LINE + "    Task description is empty!\n" + LINE);
+                    }
+                    this.splitInput[1] = null;
+                    this.splitInput[2] = null;
+                } catch (AragornException e) {
+                    System.out.println(e.getMessage());
+                }
+                break;
+
+            case "DEADLINE":


the command types can perhaps be stored as constants or you could probably use enums to avoid the usage of magic literals.

sevenseasofbri · 2024-02-19T11:48:00Z

+
+import exceptions.AragornException;
+import commands.inputParser;
+import tasks.*;


avoid using wildcard imports

sevenseasofbri · 2024-02-19T11:48:13Z

+
+public class Aragorn {
+
+    private static final String LINE =  "    __________________________________________________________\n";


good use of constants

sevenseasofbri · 2024-02-19T11:49:14Z

+        while(true) {
+            String userInput = in.nextLine();
+            String commandType = inputParser.commandIdentifier(userInput);
+            try {
+                inputParser input = new inputParser(userInput.trim(), commandType);
+
+
+                switch (commandType) {
+                    case "LIST":
+                        if (listLength == 0) {


this is 4 levels of nesting, it makes the code hard to read and debug if any problems arise. consider refactoring this to multiple methods.

sevenseasofbri · 2024-02-19T11:49:52Z

+            "\n" +
+            "    \"bye\": Closes the program.\n";
+
+    public static void main(String[] args) throws AragornException {


this function is also very long (>30 LOC)

sevenseasofbri · 2024-02-19T11:50:49Z

+public class Deadline extends Task {
+
+    public String deadline;
+    //public static String taskType = "D";


avoid leaving in commented-out code. it can reduce readability

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#delete-dead-code

# Conflicts (resolved): # src/main/java/tasks/Deadline.java

This reverts commit 2b44a52.

branch-Level-9

A-JavaDoc

vimalapugazhan added 4 commits February 6, 2024 11:43

Changed bot name to Aragorn and implemented Echo for level 1

ab7d967

Completed Level 2

5c6c705

Implemented basic functionality for level 3

0eb2de1

Completed Level - 3 fully

e2343e0

tayponghee reviewed Feb 8, 2024

View reviewed changes

luozihui2003 reviewed Feb 8, 2024

View reviewed changes

vimalapugazhan added 11 commits February 9, 2024 02:56

Completed Level - 4.

b8381d7

Added messages to stop double marking and unmarking

8b4b87b

Added commandIdentifier method

57b6d91

added input parser to split input to description and task conditions

ccd3da5

added /help command and changes to case statements for readablility

715c55b

prints empty list message

f0eae4a

Refactor inputParser and commandIdentifier into seperate class. Added…

71994ee

… exceptions

Merge branch 'branch-Level-5'

5e83761

Added packages

99799cb

Added more exceptions for event task and formatted printing

bfe0e6b

Merge branch 'branch-A-Packages'

95805b8

sevenseasofbri reviewed Feb 19, 2024

View reviewed changes

vimalapugazhan added 9 commits February 21, 2024 10:42

Implemented ArrayList instead of Array of tasks

5ae1ba1

Added delete function and removed commented code

1883fae

Level - 7

bb9cd02

Merge branch 'branch-Level-6'

b699596

Merge branch 'branch-Level-7'

8a24c8d

# Conflicts (resolved): # src/main/java/tasks/Deadline.java

removed unnecessary throw

a5baff9

achieved A-Jar

afaa95b

fixed file path and directory creation

8fd188b

Remove additional white space bug for todo type tasks

69ce325

vimalapugazhan and others added 24 commits February 27, 2024 14:45

Refactor decision making code from main

293f494

Replace magic string in main

b0f1acc

Remove most magic string. Refactor code.

b47a8a7

Merge branch 'MoreOOP'

7d25560

Fix file visibility

92e02c7

Fix Spacing

8a35d1f

Implement Find Task command

2b44a52

Merge branch 'branch-Level-9'

f82932b

Revert "Implement Find Task command"

78ff600

This reverts commit 2b44a52.

no message

0c91c3a

complete level-7

a0889ec

Merge pull request #1 from vimalapugazhan/branch-Level-9

9a357a8

branch-Level-9

Modify command list and replace magic string

2b37913

Refactor Parser methods

3e38bc3

change package name and imports

976252d

Combine case statements for DELETE and UNMARK commands

1fbd29e

Write documentations for some methods

f7cf060

Add additional documentation

d60df8f

Merge pull request #2 from vimalapugazhan/branch-A-JavaDoc

0536bf5

A-JavaDoc

Complete User guide

c73af7b

Merge branch 'branch-A-JavaDoc'

726b533

Merge branch 'master' of https://github.com/vimalapugazhan/ip

744f5d9

Update README.md

c143f9e

Update README.md 2

c6dd136


		import exceptions.AragornException;

		public class inputParser {


		public class Aragorn {

		private static final String LINE = " __________________________________________________________\n";

Uh oh!

Conversation

vimalapugazhan commented Feb 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sevenseasofbri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants