[Rawal Aarav] iP by aaravrawal52 · Pull Request #172 · nus-cs2113-AY2324S2/ip

aaravrawal52 · 2024-02-06T12:27:09Z

No description provided.

This reverts commit 6769e07.

kirangeofran · 2024-02-07T05:40:29Z

+import java.util.List;
+import java.util.Scanner;
+
+public class G_one {


the public class G_one should be named using PacalCase ( gOne/GOne)

kirangeofran · 2024-02-07T05:46:44Z

@@ -0,0 +1,132 @@
+import java.util.ArrayList;


Good listing of imported classes explicitly.

kirangeofran · 2024-02-07T06:22:44Z

+            System.out.println("OK, I've marked this task as not done yet:");
+            System.out.println("  " + task);
+        } else {
+            System.out.println("Invalid task number.");


good use of error handling

kirangeofran · 2024-02-07T06:27:20Z

+        G_one g_one = new G_one();
+        g_one.start();
+    }
+}


perhaps you could add some comments to make your code easier to understand :)

dextboy · 2024-02-07T06:35:52Z

+        System.out.println("Hello! I'm G.one");
+        System.out.println("--------------------------------------");
+        Scanner scanner = new Scanner(System.in);
+        boolean flag = true;


Should this Boolean variable be named to sound like booleans? eg. isRunning etc

dextboy · 2024-02-07T06:38:22Z

+        }
+
+        System.out.println("Goodbye!");
+        scanner.close();


Very nice detail to close scanner in order to indicate that you're done with its underlying stream!

dextboy · 2024-02-07T06:42:47Z

+    public void start() {
+        System.out.println("Hello! I'm G.one");
+        System.out.println("--------------------------------------");
+
+        Scanner scanner = new Scanner(System.in);
+        boolean flag = true;
+
+        while (flag) {
+            System.out.print("Whats up? ");
+            String userInput = scanner.nextLine();
+
+            if (userInput.equalsIgnoreCase("bye")) {
+                flag = false;
+            } else if (userInput.equalsIgnoreCase("list")) {
+                displayTaskList();
+            } else {
+                processUserInput(userInput);
+            }
+        }


Very good use of K&R style brackets!

dextboy · 2024-02-07T06:46:33Z

@@ -0,0 +1,13 @@
+public class DeadlineTask extends Task {


Great that DeadlineTask Class name is a noun and written in PascalCase!

dextboy · 2024-02-07T06:53:49Z

+    }
+
+    private void addEventTask(String descriptionAndTime) {
+        String[] parts = descriptionAndTime.split(" /from ");


Good that array specifiers are attached to the type not the variable!

dextboy · 2024-02-07T07:21:52Z

+        if (userInput.startsWith("todo")) {
+            addTodoTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("deadline")) {
+            addDeadlineTask(userInput.substring(9).trim());
+        } else if (userInput.startsWith("event")) {
+            addEventTask(userInput.substring(6).trim());
+        } else if (userInput.startsWith("mark")) {
+            markTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("unmark")) {
+            unmarkTask(userInput.substring(7).trim());
+        } else if (userInput.equalsIgnoreCase("list")) {
+            displayTaskList();
+        } else {
+            System.out.println("Invalid command.");
+        }


Good that the if-else statements follows the java conventions!

BestDownLoader365 · 2024-02-08T04:08:19Z

+        Task task = new DeadlineTask(parts[0], parts[1]);
+        tasks.add(task);
+        System.out.println("Alright buddy, Added this:");
+        System.out.println("  " + task);
+        printTaskCount();


SLAP Hard
Avoid having multiple levels of abstraction within a code fragment
You can try write all things in printTaskCount() and rename this function to make more sense

BestDownLoader365 · 2024-02-08T17:43:22Z

+        if (parts.length != 2) {
+            System.out.println("Invalid event format.");
+            return;
+        }
+        String[] timeParts = parts[1].split(" /to ");
+        if (timeParts.length != 2) {
+            System.out.println("Invalid event format.");
+            return;
+        }
+        Task task = new EventTask(parts[0], timeParts[0], timeParts[1]);
+        tasks.add(task);
+        System.out.println("Alright buddy, Added this:");
+        System.out.println("  " + task);
+        printTaskCount();
+    }


No Deep nesting, Goood

BestDownLoader365 · 2024-02-08T17:44:10Z

+    private void processUserInput(String userInput) {
+        if (userInput.startsWith("todo")) {
+            addTodoTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("deadline")) {
+            addDeadlineTask(userInput.substring(9).trim());
+        } else if (userInput.startsWith("event")) {
+            addEventTask(userInput.substring(6).trim());
+        } else if (userInput.startsWith("mark")) {
+            markTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("unmark")) {
+            unmarkTask(userInput.substring(7).trim());
+        } else if (userInput.equalsIgnoreCase("list")) {
+            displayTaskList();
+        } else {
+            System.out.println("Invalid command.");


Good oop implementation

BestDownLoader365 · 2024-02-08T17:44:26Z

+    }
+
+    private void unmarkTask(String taskNumberStr) {
+        int taskNumber = Integer.parseInt(taskNumberStr) - 1;


Clear variable name

BestDownLoader365 · 2024-02-08T17:45:20Z

+    }
+
+    private void addDeadlineTask(String descriptionAndBy) {
+        String[] parts = descriptionAndBy.split(" /by ");


Also clear variable name

sevenseasofbri

Overall, code is OK. Looks like Lvl 5 has not been done yet, might want to work on that. Naming and adherance to coding standard is good. Mixed usage of abstraction, it can be more consistent. Good job 👍🏽

sevenseasofbri · 2024-02-19T02:32:27Z

+        /*String logo = " ____        _        \n"
                + "|  _ \\ _   _| | _____ \n"
                + "| | | | | | | |/ / _ \\\n"
                + "| |_| | |_| |   <  __/\n"
-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+                + "|____/ \\__,_|_|\\_\\___|\n";*/
+
+        //System.out.println("Hello from\n" + logo);


Avoid leaving in commented out code. It reduces readbility.

sevenseasofbri · 2024-02-19T02:33:41Z

+        //System.out.println("Hello from\n" + logo);
+        System.out.println("Hello! I'm G.one");
+        System.out.println("--------------------------------------");
+        Scanner scanner = new Scanner(System.in);


Consider naming this object a bit more intuitively? Someting along the lines of input ?

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#use-name-to-explain

sevenseasofbri · 2024-02-19T02:35:03Z

+        System.out.println("Hello! I'm G.one");
+        System.out.println("--------------------------------------");
+        Scanner scanner = new Scanner(System.in);
+        boolean flag = true;


Boolean variables should be named to sound like booleans. That is, it should be asking a question with a true/false answer.
See: https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#use-name-to-explain
Also see: https://se-education.org/guides/conventions/java/basic.html#naming

sevenseasofbri · 2024-02-19T02:36:14Z

+        System.out.println("--------------------------------------");
+        Scanner scanner = new Scanner(System.in);
+        boolean flag = true;
+        while (flag){


while (flag) {
spacing between ) and { will improve readability

sevenseasofbri · 2024-02-19T02:38:50Z

+        while (flag){
+            System.out.print("Whats up? ");
+            String userInput = scanner.nextLine();
+            if (userInput.equalsIgnoreCase("bye")){


Avoid magic literals in the code. Maybe consider using a static final variable instead.

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#avoid-magic-numbers

sevenseasofbri · 2024-02-19T02:49:12Z

+    private void processUserInput(String userInput) {
+        if (userInput.startsWith("todo")) {
+            addTodoTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("deadline")) {
+            addDeadlineTask(userInput.substring(9).trim());
+        } else if (userInput.startsWith("event")) {
+            addEventTask(userInput.substring(6).trim());
+        } else if (userInput.startsWith("mark")) {
+            markTask(userInput.substring(5).trim());
+        } else if (userInput.startsWith("unmark")) {
+            unmarkTask(userInput.substring(7).trim());
+        } else if (userInput.equalsIgnoreCase("list")) {
+            displayTaskList();
+        } else {


Good use of abstraction. However, can the substring and trim portion be separated to a different function dedicated to getting a substring from the input? Mainly because this will reduce complicated expressions and improve the overall readability of this function.

sevenseasofbri · 2024-02-19T02:55:03Z

+    }
+
+    private void addDeadlineTask(String descriptionAndBy) {
+        String[] parts = descriptionAndBy.split(" /by ");


parts is not a very good name. It is unclear as to what it is referring to.

https://nus-cs2113-ay2324s2.github.io/website/se-book-adapted/chapters/codeQuality.html#use-name-to-explain

sevenseasofbri · 2024-02-19T02:56:17Z

+        printTaskCount();
+    }
+
+    private void addDeadlineTask(String descriptionAndBy) {


consider using a different name instead of descriptionAndBy. It reads a bit confusingly. Maybe deadlineDetails ?

sevenseasofbri · 2024-02-19T02:58:58Z

+    public static void main(String[] args) {
+        G_one g_one = new G_one();
+        g_one.start();
+    }


Again, variable names should be in camelCase and classnames in PascalCase.

sevenseasofbri · 2024-02-19T03:01:35Z

+
+
+
+


remove unnecessary space

This reverts commit 7b5aff0.

Aarav rawal added 6 commits February 3, 2024 13:29

level 0

f26340e

W3_L1

ee749ce

W3_L3

6769e07

Revert "W3_L3"

41c5cd8

This reverts commit 6769e07.

W3_L2

eb291c6

W3_L3

d7a3635

aaravrawal52 changed the title IP [Rawal Aarav] iP Feb 7, 2024

W4_L1

85dd0b1

kirangeofran reviewed Feb 7, 2024

View reviewed changes

dextboy reviewed Feb 7, 2024

View reviewed changes

BestDownLoader365 reviewed Feb 8, 2024

View reviewed changes

sevenseasofbri reviewed Feb 19, 2024

View reviewed changes

Aarav rawal and others added 13 commits February 21, 2024 11:02

Week 5

33709ab

Delete src/main/java/Duke.java

4835820

no message

f1df4d2

Merge branch 'master' of https://github.com/aaravrawal52/ip

b54eb2e

no message

eefe4c6

level-7

eb794a6

level-8

7b145a3

A-Javadoc

7b5aff0

Revert "A-Javadoc"

c25c207

This reverts commit 7b5aff0.

no message

e6f66e2

no message

22aa678

no message

adbbdb2

no message

8b65029

Uh oh!

Conversation

aaravrawal52 commented Feb 6, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sevenseasofbri left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants