[CS2113-W15-1] LifeTracker by MingEn82 · Pull Request #94 · nus-cs2113-AY2223S2/tp

MingEn82 · 2023-03-16T02:29:13Z

No description provided.

Geeeetyx

Overall, the DG is easy to understand

Geeeetyx · 2023-03-29T05:10:58Z

+
+### Storage Component
+
+![storage-class-diagram](./uml/storage-class-diagram.png)


Storage Class diagram is not working

Geeeetyx · 2023-03-29T05:15:29Z


 * *glossary item* - Definition
+___
+##Instructions for manual testing


Maybe could give more detailed instructions for manual testing

Geeeetyx · 2023-03-29T05:19:33Z

+The user chooses to update his weight by inputting the number `2`. This causes the state of the user's details to be 
+modified and the user's weight as well as his caloric limit will be updated in accordance to the new weight entered.
+
+> Insert UML diagram showing the update process


just note that perhaps y'all have yet to add this diagram in

Geeeetyx · 2023-03-29T05:22:26Z

+_LifeTracker_ can also keep track of the exercises that users have done and factor it in to their daily calories lost. This allows
+the user to keep track of their net calorie gain on a daily basis.
+
+### User Stories


a bug with your user stories table, it does not show up as intended on the DG website

Khulon

DGs look well thought of and designed! Good job!

Khulon · 2023-03-29T05:21:58Z

Very simple, concise and neat. It is easy to understand as it covers the essential commands and classes required.

Khulon · 2023-03-29T05:26:28Z

Is the line leading to the interface supposed to turn into a solid line?

Khulon · 2023-03-29T05:28:51Z

Is this PowerPoint? I think prof might want us to use plantUML.

Khulon · 2023-03-29T05:44:08Z

Would the use of different commands to get to different functions mean parallel paths?

waiter-palypoo

Some bugged images and UML notation errors

waiter-palypoo · 2023-03-29T05:22:38Z

+---
+### Architecture

+![](../out/docs/uml/Architecture/architecture.svg)


Architecture diagram does not show on the DG

waiter-palypoo · 2023-03-29T05:23:44Z

+
+### Storage Component
+
+![storage-class-diagram](./uml/storage-class-diagram.png)


Class diagram image is broken on the DG

waiter-palypoo · 2023-03-29T05:33:58Z

+with the current user and meal storage state. `user` and `meals` will point to the user storage and meal state 
+respectively.
+
+<img src="uml/ViewUserCommandSD1.png" alt="Sequence Diagram 1" width="500">


Incorrect use of the par frame, the program does not seem to implement multi-threading through the Thread class or Runnable interface.

waiter-palypoo · 2023-03-29T05:38:54Z

+This calls the getter method `getWeight()` in the entity `User` to return the current weight of the user
+and initializes the variable `weight` with that value. 
+
+<img src="uml/ViewUserCommandSD2.png" alt="Sequence Diagram 2" width="500">


The label for the "alt" frame should have the diagonal "folded in" bottom right corner (same for opt and par frames)

waiter-palypoo · 2023-03-29T05:44:47Z

+by inputting the number `6`. This calls the getter method `getCaloricLimit()` in the entity `User` to return the
+current daily caloric limit of the user and initializes the variable `caloricLimit` with that value. 
+
+<img src="uml/ViewUserCommandSD3.png" alt="Sequence Diagram 2" width="500">


If you want to split the alt frame into multiple diagrams, use reference frames to indicate on the higher level sequence diagram where the new diagram is in the sequence.

chiayuxuan · 2023-03-30T03:46:49Z

+
+### Storage Component
+
+![storage-class-diagram](./uml/storage-class-diagram.png)


Storage class is not showing up

chiayuxuan · 2023-03-30T03:48:53Z

+which meal they want to delete by viewing the mealData.csv file.

-{Describe the target user profile}
+<img src="uml/DeleteMealCommand1.png" alt="Sequence Diagram" width="500">


Is it possible to add the deletion of a Meal Object?

erjunze · 2023-03-30T03:36:29Z

+___
+##Instructions for manual testing


Heading formatting is broken due to missing newline between your glossary list and next heading

erjunze · 2023-03-30T03:47:26Z

+by inputting the number `6`. This calls the getter method `getCaloricLimit()` in the entity `User` to return the
+current daily caloric limit of the user and initializes the variable `caloricLimit` with that value. 
+
+<img src="uml/ViewUserCommandSD3.png" alt="Sequence Diagram 2" width="500">


The alt label should have the bottom right corner folded in

It is unclear what the ["6"] refer to (there is also no step 6 listed)

It seems that getCaloricLimit() needs to be run before showDailyCalorieLimit, then they should not be run in parallel

The arrow of the self invocation for print out daily calorie limit should point to the start of its activation bar

In the image, your textbox for showDailyCalorieLimit is selected

erjunze · 2023-03-30T03:57:51Z

+1. Using a one-line command in their CLI in the format `add [DATE] /on [MEAL_TYPE] /type [FOOD_INDEX] /foods`
+2. Typing `add` into the CLI and following the printed prompts to enter the date in the specified format, type of meal and specific food.
+
+<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">


It is unclear what your alt conditions are referring to (your explanations do not mention what is full command)

Alt label bottom right corner not folded in

Self invocation arrow not pointing at start of activation bar

Does your AddMealCommand go ahead with creating a new Meal even when userInput is neither full command nor add?

erjunze · 2023-03-30T03:59:35Z

+with the current user and meal storage state. `user` and `meals` will point to the user storage and meal state 
+respectively.
+
+<img src="uml/ViewUserCommandSD1.png" alt="Sequence Diagram 1" width="500">


Are you sure the User and CalorieUi classes are only created when this command is run?

Implemented logger & added logging

YC-Michael

Generally, good job! Can consider using plantUML for sequence diagrams and give example inputs and explain the steps using those examples.

YC-Michael · 2023-03-31T02:21:41Z

+
+### Storage Component
+
+![storage-class-diagram](./uml/storage-class-diagram.png)


Storage-class-diagram is not showing up. If you are using plantUML, simply copy paste the image over to your DG from the UML file.

YC-Michael · 2023-03-31T02:25:35Z

+1. Using a one-line command in their CLI in the format `add [DATE] /on [MEAL_TYPE] /type [FOOD_INDEX] /foods`
+2. Typing `add` into the CLI and following the printed prompts to enter the date in the specified format, type of meal and specific food.
+
+<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">


The box label for alt should consist of three lines.

YC-Michael · 2023-03-31T02:27:49Z

+
+<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">
+
+Step 1. As seen from the sequence diagram above, when the AddMealCommand is executed via the `execute` method in 


Perhaps giving an example input and showing it in the steps might help readers understand it better.

YC-Michael · 2023-03-31T02:29:15Z

+1. Using a one-line command in their CLI in the format `add [DATE] /on [MEAL_TYPE] /type [FOOD_INDEX] /foods`
+2. Typing `add` into the CLI and following the printed prompts to enter the date in the specified format, type of meal and specific food.
+
+<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">


Arrow from User to :AddMealCommand is missing a name for method call which is execute().

YC-Michael · 2023-03-31T02:32:07Z

+1. Using a one-line command in their CLI in the format `add [DATE] /on [MEAL_TYPE] /type [FOOD_INDEX] /foods`
+2. Typing `add` into the CLI and following the printed prompts to enter the date in the specified format, type of meal and specific food.
+
+<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">


It might be helpful to explain the functions in the alt portion.

YC-Michael · 2023-03-31T02:35:11Z

+which meal they want to delete by viewing the mealData.csv file.

-{Describe the target user profile}
+<img src="uml/DeleteMealCommand1.png" alt="Sequence Diagram" width="500">


The arrow head for the return dotted line is not visible.

YC-Michael · 2023-03-31T02:40:47Z

+with the current user and meal storage state. `user` and `meals` will point to the user storage and meal state 
+respectively.
+
+<img src="uml/ViewUserCommandSD1.png" alt="Sequence Diagram 1" width="500">


Par frame should not be used as program is not multi-threaded.

YC-Michael · 2023-03-31T02:43:10Z

+by inputting the number `6`. This calls the getter method `getCaloricLimit()` in the entity `User` to return the
+current daily caloric limit of the user and initializes the variable `caloricLimit` with that value. 
+
+<img src="uml/ViewUserCommandSD3.png" alt="Sequence Diagram 2" width="500">


When taking a screenshot, do take note of the highlights.

YC-Michael · 2023-03-31T02:44:27Z

+- Prefers typing to mouse interactions
+- Is reasonably comfortable using CLI apps
+
+### Value proposition:


Value proposition sounds interesting!

YC-Michael · 2023-03-31T02:45:24Z

+_LifeTracker_ can also keep track of the exercises that users have done and factor it in to their daily calories lost. This allows
+the user to keep track of their net calorie gain on a daily basis.
+
+### User Stories


Please check the formats in intelliJ before merging it.

added MingEn82 PPP pdf

…ingEn

bug fixes

Branch debugging

Add Motivational exercise message Feature

Add Target Weight Feature

Branch mustafa

Branch fix target

Add meal exercises examples

Fix gradle errors

update DG manual testing section and PPP

fixed table in UG

fixed typo

updated about us page

…names

Branch hamada

MingEn82 force-pushed the master branch from a617745 to da9b3a3 Compare March 19, 2023 16:08

Geeeetyx reviewed Mar 29, 2023

View reviewed changes

Khulon reviewed Mar 29, 2023

View reviewed changes

waiter-palypoo reviewed Mar 29, 2023

View reviewed changes

chiayuxuan reviewed Mar 30, 2023

View reviewed changes

erjunze reviewed Mar 30, 2023

View reviewed changes

kyrixn pushed a commit to kyrixn/tp that referenced this pull request Mar 30, 2023

Merge pull request nus-cs2113-AY2223S2#94 from hrithie/hrithieMenon-v2.0

f2be2cd

Implemented logger & added logging

YC-Michael reviewed Mar 31, 2023

View reviewed changes

MingEn82 and others added 7 commits March 31, 2023 15:48

Merge pull request #121 from MingEn82/master

68671ee

added MingEn82 PPP pdf

test

5792300

prev commit

6411442

Merge branch 'master' of https://github.com/MingEn82/tp into branch-M…

7720aeb

…ingEn

fixed bugs

15ca2b8

removed dependencies

e65413e

Merge pull request #122 from MingEn82/branch-MingEn

84927de

bug fixes

vishnuvk47 pushed a commit to vishnuvk47/tp that referenced this pull request Mar 31, 2023

Merge pull request nus-cs2113-AY2223S2#94 from tyuyang/branch-debugging

00cb959

Branch debugging

Koh-Jing-Jie-Marcus and others added 14 commits April 1, 2023 13:05

Add Motivational exercise message Feature

c937583

Merge pull request #166 from Koh-Jing-Jie-Marcus/Branch-Motivate

feb14dd

Add Motivational exercise message Feature

Add Target Weight Feature

ecef301

Merge pull request #168 from Koh-Jing-Jie-Marcus/branch-TargetWeight

97f1b14

Add Target Weight Feature

Fix bugs ('List' command for exercises)

9684541

Add functionality to delete exercise

a9a72df

Try and fix gradle errors

fe3e6c0

Merge pull request #169 from MustafaAH10/branch-Mustafa

766de35

Branch mustafa

Update userData

985e9be

Fix target weight implementation

fcb06c3

Merge pull request #170 from Koh-Jing-Jie-Marcus/branch-FixTarget

79ebd07

Branch fix target

Add meal exercises examples

2abfef4

Merge pull request #171 from Koh-Jing-Jie-Marcus/branch-CommonExercises

e62f9c8

Add meal exercises examples

Fix bugs (Exercise Storage issue)

d964189

MustafaAH10 and others added 30 commits April 10, 2023 14:15

Merge pull request #232 from MustafaAH10/branch-Mustafa

00c3a9d

Fix gradle errors

Merge branch 'master' of https://github.com/AY2223S2-CS2113-W15-1/tp

82b2389

Update UserGuide.md

ed40657

Update README.md

33f7bcc

Update UserGuide.md

a569d55

Update koh-jing-jie-marcus.md

35992c0

Update koh-jing-jie-marcus.md

6a5d5aa

Update tj-hoo.md

8486ed7

Update UserGuide.md

4ed9a71

Update UserGuide.md

2e06bcc

Update UserGuide.md

308e454

Update README.md

5c7c2fe

Update tj-hoo.md

7354b64

Merge branch 'master' of https://github.com/AY2223S2-CS2113-W15-1/tp

112236d

update DG manual testing section and PPP

0f0c95f

Merge pull request #233 from Masahiro21/branch-Hamada

29e19f6

update DG manual testing section and PPP

move ppp to docs folder

9507e52

fixed table in UG

9d8eaa1

Merge pull request #234 from MingEn82/branch-MingEn

f4a37a8

fixed table in UG

fixed typo

57a8e32

Merge pull request #236 from MingEn82/branch-MingEn

af31091

fixed typo

remove ppp from docs folder

89f5702

Merge branch 'master' of https://github.com/AY2223S2-CS2113-W15-1/tp

e7888f2

Merge branch 'master' into branch-Hamada

3da4d49

updated about us page

f7759b9

Merge pull request #237 from MingEn82/branch-MingEn

5557572

updated about us page

Merge branch 'master' of https://github.com/AY2223S2-CS2113-W15-1/tp

1e1246f

Merge branch 'master' into branch-Hamada

e23189c

fixed bug in updateUserCommand to trim any additional spaces between …

129821d

…names

Merge pull request #238 from Masahiro21/branch-Hamada

57bd5fc

Branch hamada


		### Storage Component

		![storage-class-diagram](./uml/storage-class-diagram.png)


		<img src="uml/AddMealCommand1.png" alt="Sequence Diagram" width="500">

		Step 1. As seen from the sequence diagram above, when the AddMealCommand is executed via the `execute` method in

Conversation

MingEn82 commented Mar 16, 2023

Uh oh!

Geeeetyx left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Khulon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

waiter-palypoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

YC-Michael left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

waiter-palypoo left a comment •

edited

Loading