[CS2113-T11-2] peNUS#35
Open
bentohset wants to merge 491 commits into
Open
Conversation
kyrixn
added a commit
to kyrixn/tp
that referenced
this pull request
Mar 14, 2023
…nit_test Add JUnit tests for Parser and EventList
vishnuvk47
pushed a commit
to vishnuvk47/tp
that referenced
this pull request
Mar 15, 2023
Add parseSavedFile
Jy- update status/ sampledata
Added test for getCoreMods, getGec, getGEN, getGESS
…into jy-archi commit
pinyoko573
reviewed
Mar 29, 2023
|  | ||
|
|
||
| ### UI Component | ||
|  |
There was a problem hiding this comment.
Neat UI component! I think Scanner and PrintStream may not be needed (if im not wrong)
|  | ||
|
|
||
| ### Logic Component | ||
|  |
There was a problem hiding this comment.
I assume this is the class diagram of the logic component, would be better if you include the methods and variables in the Logic view, same for Model and Storage
| Given below is an example usage scenario of the 2 types of modules and how the add module mechanism behaves at each step. | ||
|
|
||
| **When a planned module is added:** | ||
| Step 1. The user launches the application for the first time. The ModuleList will be initialised with the initial module list state if provided in `penus.txt`. |
There was a problem hiding this comment.
Great use of using step by step to explain the sequence diagram!
| Priorities: High (must have) - `* * *`, Medium (nice to have) - `* *`, Low (unlikely to have) - `*` | ||
|
|
||
| ## User Stories | ||
| | Priority | Version | As a ... | I want to ... | So that I can ... | |
There was a problem hiding this comment.
Good use of priority to show the main features of the application!
Edit dg diagrams and Add Javadoc
Add diagram for GradeClass
# Conflicts: # src/test/java/seedu/penus/storage/ResourceStorageTest.java
# Conflicts: # src/main/java/seedu/penus/Penus.java # src/main/java/seedu/penus/common/exceptions/CourseIndexOutOfBoundsException.java # src/main/java/seedu/penus/common/exceptions/InvalidCourseIndexException.java # src/main/java/seedu/penus/common/exceptions/InvalidIndexException.java # src/main/java/seedu/penus/logic/utils/Grade.java # src/main/java/seedu/penus/model/User.java # src/main/java/seedu/penus/modules/ModuleList.java # src/main/java/seedu/penus/parser/CommandParser.java # src/main/java/seedu/penus/storage/FileStorage.java # src/main/java/seedu/penus/ui/Ui.java # src/test/java/seedu/penus/ParserTest.java # src/test/java/seedu/penus/logic/utils/GradeTest.java # text-ui-test/EXPECTED.TXT
Storage junit tests
Edit AboutUs
Updated UG
Update teammate's PPP
Final edits PPP DG
Edited DG and own PPP
Fix images
Fix images
Shorten image
Resize image
resize image
format images
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peNUS is a desktop app for university students to plan their modules, with easy searching and adding of modules, as well as CAP tracking and prerequisite information.