[CS2113-T15-2] SecureNUS#32
Conversation
…edit-time fixed bugs in parser
Thunderdragon221
left a comment
Thunderdragon221
left a comment
There was a problem hiding this comment.
Overall good DG with minor formatting errors.
| !include Style.puml | ||
| title UI Component Diagram | ||
| actor User | ||
| node SecureNUS |
There was a problem hiding this comment.
Maybe represent the classes using the standard representation adopted by CS2113 instead of 3-dimensional boxes?
| frame Backend { | ||
| node Backend | ||
| } | ||
| Commands --> SecureNUS.SecureNUS |
There was a problem hiding this comment.
Maybe include details as part of the arrows for additional clarity?
| @startuml | ||
| 'https://plantuml.com/sequence-diagram | ||
|
|
||
| autonumber |
There was a problem hiding this comment.
Maybe omit autonumbering to follow the standard practice adopted by CS2113?
| SecretMaster -[dotted]-> SecretSearcher: alters | ||
| } | ||
| () SecureNUS -[dotted]right-> SecretMaster :requests alteration \n of data via | ||
| SecretMaster <-[dotted]right-> Backend : sends data for export OR\n collects data for import |
There was a problem hiding this comment.
I like the clarity described by the arrows in the diagram.
ysl-28
left a comment
ysl-28
left a comment
There was a problem hiding this comment.
DG is generally clear and understandable
|
|
||
| The Sequence Diagram below shows how the components interact with each other for the scenario where the user creates a new basic password initiated using the command `new password.` | ||
|
|
||
| Sequence Diagram |
There was a problem hiding this comment.
It might not be too clear that methods like extractName() and inquireURL() are only being called in AddBasicPassword and not in the other classes that inherit from Command.
There was a problem hiding this comment.
For methods like inquireURL() that return a string, perhaps the return arrows should be labelled with that they are returning?
There was a problem hiding this comment.
Might it be clearer to show object deletion at the end of its lifeline too?
|
|
||
| <img src="./DGDiagramsCreator/DGUsedDiagrams/CommandComponent.png" width="100%" /> | ||
|
|
||
| The Command consist of Command abstract class that handles all of its command constructors and executions through its child classes. The user inputs command in Ui, that is parsed in Parser, and then institiated in and then executed in Command classes. |
| <img src="./DGDiagramsCreator/DGUsedDiagrams/ArchitectureDiagram.png" width="100%" /> | ||
|
|
||
|
|
||
| This **Architecture Diagram** explains the high-level design of the App. |
There was a problem hiding this comment.
Perhaps use the standard CS2113 representation for diagrams? (instead of using the symbols)
| ## Target user profile: | ||
|
|
||
|
|
||
|
|
||
| * has a need to manage a significant number of passwords | ||
| * prefer desktop apps over other types | ||
| * can type fast | ||
| * prefers typing to mouse interactions | ||
| * is reasonably comfortable using CLI apps | ||
|
|
There was a problem hiding this comment.
May consider being more specific when defining the target users, and elaborate how the value proposition matches the needs of the target users.
| * is reasonably comfortable using CLI apps | ||
|
|
||
|
|
||
| ## Value proposition: |
There was a problem hiding this comment.
May consider defining the scope more clearly by specifying the boundary beyond which the app will not help.
|
|
||
| This is the main component that initialises all other components and connects them when the application is running. | ||
|
|
||
| ## SecretStorage Component |
There was a problem hiding this comment.
I like how the system is divided into the separate components in the documentation. The component diagrams are clear and simple.
|
|
||
| The Sequence Diagram below shows how the components interact with each other for the scenario where the user creates a new basic password initiated using the command `new password.` | ||
|
|
||
| Sequence Diagram |
There was a problem hiding this comment.
In the sequence diagram, a semicolon should be added before the class name. Unnamed instances of a class should be denoted as :Class.
trying to resolve inf loop: 1
Remove infinite loop in github tests
# Conflicts: # src/test/java/seedu/duke/command/AddCommandTest.java # src/test/java/seedu/duke/command/DeleteCommandTest.java
# Conflicts: # src/main/java/seedu/duke/Backend.java # src/main/java/seedu/duke/Parser.java # src/main/java/seedu/duke/exceptions/secrets/FolderExistsException.java # src/main/java/seedu/duke/secrets/CreditCard.java # src/test/java/seedu/duke/DukeTest.java
# Conflicts: # src/main/java/seedu/duke/Backend.java # src/main/java/seedu/duke/command/ListCommand.java # src/main/java/seedu/duke/exceptions/secrets/FolderExistsException.java # src/main/java/seedu/duke/secrets/CreditCard.java # src/test/java/seedu/duke/DukeTest.java # src/test/java/seedu/duke/command/ExitCommandTest.java
Checkstyle fixes (incl. remove ExitCommandTest)
v2.0 release
v2.0 release
Final edits to edit command
Resized images
Center images
Finalise PPP
Finalise PPP
Convert current Jarfile name to SecureNUS.jar
10 participants
SecureNUS is a desktop CLI app for managing and storing passwords. SecureNUS provides the functionalities of a regular password manager tool, but on CLI. Simple and efficient to use especially for fast typists.