[Tze Loong] iP by TzeLoong · Pull Request #213 · nus-cs2113-AY2223S2/ip

TzeLoong · 2023-02-02T05:01:32Z

No description provided.

Mark as Done

nicholas132000 · 2023-02-02T07:45:20Z

+import java.util.Scanner;
+
 public class Duke {
-    public static void main(String[] args) {


Consistent 4 spaces indent throughout the code, good job

nicholas132000 · 2023-02-02T07:48:23Z

+        greet_user();
+        int counter = 0;
+
+        Tasks[] list_of_tasks = new Tasks[101]; // Following the assumption that there will be no more than 100 tasks


Perhaps you try using camelcase when naming variables. Eg. listOfTasks

nicholas132000 · 2023-02-02T07:52:25Z

@@ -0,0 +1,23 @@
+public class Tasks {


Perhaps you could name this class as "Task" (singular) instead as it refers to one task

nicholas132000 · 2023-02-02T07:54:08Z

+        System.out.println("How can i help u? \n");
+    }
+
+    public static void echo() {


Good job for using a verb to name this method

SongZijin

In general, the code is quite clear, however, there is a lot of potential for clearer and more concise code.

SongZijin · 2023-02-02T07:54:10Z

+            if ("list".equals(input)) {
+                System.out.println("Here are the tasks in your list: ");
+                for (int i = 0; i < counter; i++) {
+                    System.out.println(
+                            i + 1 + "." + " " + list_of_tasks[i].getStatusIcon() + " " + list_of_tasks[i].description);
+                }
+            } else if (input.length() >= 4 && input.substring(0, 4).equals("mark")) {
+                Integer index = Integer.valueOf(input.substring(5, input.length()));
+                list_of_tasks[index - 1].markAsDone();
+                System.out.println("Nice! This task is completed");
+                System.out
+                        .println(list_of_tasks[index - 1].getStatusIcon() + " " + list_of_tasks[index - 1].description);
+            } else if (input.length() >= 6 && input.substring(0, 6).equals("unmark")) {
+                Integer index = Integer.valueOf(input.substring(7, input.length()));
+                list_of_tasks[index - 1].markAsUnDone();
+                System.out.println("Ok, This task is still not complete");
+                System.out
+                        .println(list_of_tasks[index - 1].getStatusIcon() + " " + list_of_tasks[index - 1].description);
+            } else {
+                System.out.println("added: " + input);
+                list_of_tasks[counter].description = input;
+                list_of_tasks[counter].isDone = false;
+                counter++;
+            }
+            scan = new Scanner(System.in);
+            input = scan.nextLine();


Since you abstracted the [greet_user()] function, it may be better if you maintain Single Level of Abstraction Principle (SLAP), and also extract this portion as a separate function

SongZijin · 2023-02-02T07:56:58Z

+        greet_user();
+        int counter = 0;
+
+        Tasks[] list_of_tasks = new Tasks[101]; // Following the assumption that there will be no more than 100 tasks


It may be better to avoid using a magic number (100) and instead define it at the top of the file as MAX_NUMBER_OF_TASKS

SongZijin · 2023-02-02T08:00:36Z

+    }
+
+    public static void main(String[] args) {
+        greet_user();


Good job on extracting this part as a separate function

SongZijin · 2023-02-02T08:01:12Z

+            if ("list".equals(input)) {
+                System.out.println("Here are the tasks in your list: ");
+                for (int i = 0; i < counter; i++) {
+                    System.out.println(
+                            i + 1 + "." + " " + list_of_tasks[i].getStatusIcon() + " " + list_of_tasks[i].description);
+                }


It may be clearer to extract these parts as separate functions to avoid nesting loops.

In progress

In-progress

cheehengk

Overall good effort in implementation.More work on SLAP with shorter methods, and classes will be helpful in future iP levels and tP.

cheehengk · 2023-02-17T07:58:28Z

+            switch (command[0]) {
+                case "todo":


Switch-case should not have different indentations.

cheehengk · 2023-02-17T07:59:11Z

+        }
+    }
+
+    public static void main(String[] args) {


Try keeping your main method short and have a parser to deal with interpreting user commands instead

cheehengk · 2023-02-17T08:00:19Z

+                    String d_by = d[1];
+                    Deadline(d_description, d_by);
+                    break;
+                case "event":


Perhaps consider using constants instead of strings, for example, COMMAND_EVENT instead of "event"

cheehengk · 2023-02-17T08:01:36Z

+                    List();
+                    break;
+                case "mark":
+                    Integer m_index = Integer.valueOf(command[1]);


m_index, u_index etc. might be easy for the original developer to understand but not for someone else reading it or another person taking over. Consider using clearer naming in this case.

cheehengk · 2023-02-17T08:02:40Z

 public class Duke {
-    public static void main(String[] args) {
+
+    private static Tasks[] list_of_tasks = new Tasks[101];


Consider other data structures, apart from a fixed size array, to make your product more scalable, especially since we are already approaching recess week :)

cheehengk · 2023-02-17T08:05:27Z

+        print_action();
+    }
+
+    public static void Event(String description, String start, String end) {


Avoid using constructor names of other classes as method name. It can be confusing and potential source of bug. Also, consider separate classes for adding new tasks.

Added JavaDoc comments

TzeLoong added 6 commits February 1, 2023 13:37

Level 0 Greet

7558b46

Level 1. Greet, Echo, Exit

dbc5dac

Level 2. Add, List

f808559

Level-3

50aad95

Mark as Done

Update Tasks.java

312117e

Coding Standard

98bc638

nicholas132000 reviewed Feb 2, 2023

View reviewed changes

SongZijin reviewed Feb 2, 2023

View reviewed changes

Level-4

2306a2a

In progress

TzeLoong changed the title ~~Tze Loong iP~~ [Tze Loong] iP Feb 12, 2023

TzeLoong added 2 commits February 16, 2023 14:29

Level-4

cb74c50

In-progress

Level-4

fe13d52

cheehengk reviewed Feb 17, 2023

View reviewed changes

TzeLoong and others added 17 commits February 17, 2023 22:49

Create Duke.jar

f5259c3

Delete Duke.jar

dc3b488

Handle errors

7b1e715

Use of ArrayList<Task>

88c2683

Delete

1712749

Save

de06295

Save

3b1d6d4

Level-7

409496b

Level-7

8c09680

Level-9

d44a21d

Added comments

1e53d33

Added JavaDoc comments

2b06b30

Merge pull request #1 from TzeLoong/A-JavaDoc

9a1c515

Added JavaDoc comments

Changes

57076f4

Changes

b847776

Changes

c8ce553

Changes

6df5295

TzeLoong and others added 7 commits March 3, 2023 23:20

Updated userguide

212cf99

Update Tasklist.java

7e9c93f

Merge branch 'master' of https://github.com/TzeLoong/ip

b624d2a

Added comments

6009396

Create ip.jar

da04bb5

Improvements for v2-updated

c7ddfbe

Improvements for v0.2-updated

1ad8a59

Conversation

TzeLoong commented Feb 2, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SongZijin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cheehengk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants