[Sebastian Soewanto] iP by SebastianSoewanto · Pull Request #205 · nus-cs2113-AY2223S2/ip

SebastianSoewanto · 2023-02-01T02:51:54Z

Up to level 3

DavidVin357

LGTM, just several naming proposals :)
Also, maybe consider switch case instead of lots if else statements. Some comments for explaining specific variables might also be nice.
Overall, it's fine in terms of code standard.

DavidVin357 · 2023-02-01T05:45:08Z

                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
+
+        String line = "____________________________________________________\n";


Seems like it is a constant, so maybe consider using static final LINE_DIVIDER (or some other similar name)?

DavidVin357 · 2023-02-01T05:49:41Z

+        String line = "____________________________________________________\n";
        System.out.println("Hello from\n" + logo);
+        System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
+        String[] list = new String[100];


I think you use this list to store the different tasks, so maybe it's better to name it as tasks? :)

DavidVin357 · 2023-02-01T05:55:09Z

+        String[] list = new String[100];
+        boolean[] isDone = new boolean[100];
+        String toFill;
+        int listCount = 0;


Maybe something like tasksCount can tell better on what you are counting here?

DavidVin357 · 2023-02-01T05:59:19Z

+        System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
+        String[] list = new String[100];
+        boolean[] isDone = new boolean[100];
+        String toFill;


I think naming it checkerContent or some other noun may better represent the meaning of the variable (verbs are more suitable to be used for the methods)

DavidVin357 · 2023-02-01T06:03:58Z

+                    else {
+                        toFill = " ";
+                    }
+                    System.out.println(i + 1 + ". [" + toFill + "] " + list[i]);


Extracting i+1 to another line as i++ may make the code a little bit more clean)

ghzr0 · 2023-02-01T13:31:37Z

+        String line = "____________________________________________________\n";
        System.out.println("Hello from\n" + logo);
        System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
        String[] list = new String[100];


Naming of ' String[ ] list ' is quite vague, maybe if possible to provide a more useful name for readability? e.g. ' String [ ] taskList '

ghzr0 · 2023-02-01T13:36:25Z

+                System.out.println(line + "Nice! I've marked this task as done:\n" + "  [X] " + list[mark - 1]);
+                System.out.print(line);
+            } else if (input.startsWith("unmark")) {
+                int unmark = Integer.parseInt(input.substring(7));


The naming of ' unmark' is a bit confusing, maybe switch to ' taskToUnmark '?

ghzr0 · 2023-02-01T13:39:50Z

+                isDone[unmark - 1] = false;
+                System.out.println(line + "OK, I've marked this task as not done yet:\n" + "  [ ] "+ list[unmark - 1]);
                System.out.print(line);
+            } else if(input.equals("list")) {


Good indentation and presenting the conditional statements, which helps the code's readability.

ghzr0 · 2023-02-01T13:46:50Z

                + "|____/ \\__,_|_|\\_\\___|\n";

-        String line = "_________________________________\n";
+        String line = "____________________________________________________\n";


Naming can be changed to avoid confusion down the code block, could change to -> e.g. 'static final String margin' (since its a repeating string pattern to be printed out)

ghzr0

Commented about code's quality

bdthanh

You should use the correct tag name so that your progress is recorded. Keep up the good work and try your best for all levels. Be careful with naming constants and list variable!

bdthanh · 2023-02-14T18:44:32Z

+        String line = "____________________________________________________\n";
        System.out.println("Hello from\n" + logo);
+        System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
+        Task[] task = new Task[100];


since the number of task can be more than 100. you can consider to use the dynamic size array list

bdthanh · 2023-02-14T18:45:34Z

        String logo = " ____        _        \n"
                + "|  _ \\ _   _| | _____ \n"
                + "| | | | | | | |/ / _ \\\n"
                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
+
+        String line = "____________________________________________________\n";


Constant should be named by CAPITAL LETTER for example String DIVIDER, String LOGO

bdthanh · 2023-02-14T18:46:44Z

+        String line = "____________________________________________________\n";
        System.out.println("Hello from\n" + logo);
+        System.out.print(line + "Hello! I'm Duke\n" + "What can I do for you?\n" + line);
+        Task[] task = new Task[100];


task should be renamed to tasks (with s)

Updated class methods.

SebastianSoewanto added 4 commits February 1, 2023 00:25

Add Greetings

12a4d6f

Add userInput

3c57457

Add List

a96a8be

Add mark to list

57d0c6a

DavidVin357 reviewed Feb 1, 2023

View reviewed changes

ghzr0 reviewed Feb 1, 2023

View reviewed changes

Add todo, event and deadline

bd71f69

bdthanh reviewed Feb 14, 2023

View reviewed changes

SebastianSoewanto added 17 commits February 16, 2023 10:47

Changed variable namings

7473a4c

Changed to dynamic size array.

fa25e2d

Updated class methods.

Add exceptions

3230034

Add package and organized classes

bb5533e

Add remove of tasks

6fa95ff

Add space for readability

ca05154

Change certain class variables to protected

b07c63e

Add find task

f44576f

Add JavaDoc

e5fb6f9

Update of JavaDoc

47689bc

Refactor a bug for empty todo

805e73b

Add automated text-ui

97208ba

Add user guide

a839b28

Major refactor to include more OOP

ca10bdd

Add save file feature.

62dee31

Minor refactoring of spelling

98a859b

Fix bug in find feature

eed248b

Conversation

SebastianSoewanto commented Feb 1, 2023

Uh oh!

DavidVin357 left a comment

Choose a reason for hiding this comment

Uh oh!

DavidVin357 Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DavidVin357 Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DavidVin357 Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghzr0 left a comment

Choose a reason for hiding this comment

Uh oh!

bdthanh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

DavidVin357 Feb 1, 2023 •

edited

Loading

DavidVin357 Feb 1, 2023 •

edited

Loading

DavidVin357 Feb 1, 2023 •

edited

Loading