[kristianachwan] iP by kristianachwan · Pull Request #204 · nus-cs2113-AY2223S2/ip

kristianachwan · 2023-02-01T01:48:36Z

No description provided.

de-yi · 2023-02-01T04:43:23Z

+                            );
+        String inputText;
+        String outputMessage;
+        while (true) {


Should this method be divided? For example, mark method, unmark method can be seperated from this method.

de-yi · 2023-02-01T04:45:06Z

+        this.isDone = true;
+    }
+    public void unmarkAsDone () {
+    this.isDone = false;


Should this be indented?

de-yi · 2023-02-01T04:46:01Z

@@ -0,0 +1,40 @@
+public class Task {
+    protected String description;


I like how you used protected variables instead of public!

de-yi · 2023-02-01T04:47:58Z

+        this.deadlineBy = deadlineBy;
+    }
+
+    @Override


I like how you used @OverRide to make sure that you are properly overriding method from its parent

de-yi · 2023-02-01T04:53:50Z

+public class Task {
+    protected String description;
+    protected boolean isDone;
+    static int numberOfTasks = 0;


Maybe numberOfTasks can be protected variable too, so that it can only be acceessed by get method:)

ArtemiszenN

Overall the code works well I think, but it is quite cluttered and readability could be improved.

ArtemiszenN · 2023-02-01T04:45:16Z

+        while (true) {
+            inputText = scanner.nextLine();
+            if (inputText.equals("list")) {
+                outputMessage = Task.getTasksList(tasks);
+            } else if (inputText.startsWith("mark")) {
+                int taskIndex = getTaskIndexFromInput(inputText);
+                tasks[taskIndex].markAsDone();
+                outputMessage = "Nice! I've marked this task as done: " + "\n\t\t"
+                        + tasks[taskIndex].toString();
+            } else if (inputText.startsWith("unmark")) {
+                int taskIndex = getTaskIndexFromInput(inputText);
+                tasks[taskIndex].unmarkAsDone();
+                outputMessage = "Ok, I've marked this task as not done: " + "\n\t\t"
+                        + tasks[taskIndex].toString();
+            } else if (inputText.startsWith("task")) {
+                String taskDescription = inputText.split("/")[0].split("task")[1].trim();
+                Task newTask = new Task(taskDescription);
+                tasks[Task.numberOfTasks - 1] = newTask;
+                outputMessage = TASK_ADDED_PREFIX + newTask.toString() + "\n\t"
+                        + getTaskAddedPostfix();
+            } else if (inputText.startsWith("todo")) {
+                String toDoDescription = inputText.split("/")[0].split("todo")[1].trim();
+                Task newTodo = new ToDo(toDoDescription);
+                tasks[Task.numberOfTasks - 1] = newTodo;
+                outputMessage = TASK_ADDED_PREFIX + newTodo.toString() + "\n\t"
+                        + getTaskAddedPostfix();
+            } else if (inputText.startsWith("deadline")) {
+                String deadlineDescription = inputText.split("/")[0].split("deadline")[1].trim();
+                String deadlineBy = inputText.split("/")[1].trim();
+                Task newDeadline = new Deadline(deadlineDescription, deadlineBy);
+                tasks[Task.numberOfTasks - 1] = newDeadline;
+                outputMessage = TASK_ADDED_PREFIX + newDeadline.toString() + "\n\t"
+                        + getTaskAddedPostfix();
+            } else if (inputText.startsWith("event")) {
+                String eventDescription = inputText.split("/")[0].split("event")[1].trim();
+                String eventStart = inputText.split("/")[1].trim();
+                String eventEnd = inputText.split("/")[2].trim();
+                Task newEvent = new Event(eventDescription, eventStart, eventEnd);
+                tasks[Task.numberOfTasks - 1] = newEvent;
+                outputMessage = TASK_ADDED_PREFIX + newEvent.toString() + "\n\t"
+                        + getTaskAddedPostfix();
+            } else if (inputText.equals("bye")) {
+                outputMessage = "Bye. Hope to see you again soon!";
+                break;
+            } else {
+                outputMessage = "Sorry, I don't understand what you said. Can you say it again?";
+            }


Should these be extracted into different functions?

ArtemiszenN · 2023-02-01T04:47:54Z

+    public static String getTasksList(Task[] tasks){
+        String tasksList = "";
+        for (int i = 0; i < numberOfTasks; i++) {
+            tasksList +=  String.format("%3d. ", (i+1)) + tasks[i].toString() + "\n\t";
+        }
+        return tasksList;
+    }


Should this function be stored outside? Or the class be changed to a TaskList which includes the array of tasks?

ArtemiszenN · 2023-02-01T04:51:18Z

+    static Task[] tasks = new Task[100];
+    static final String TASK_ADDED_PREFIX = "Got it. I've added this task:\n\t";


Should these variables be explicitly stated public/protected/private?

ArtemiszenN · 2023-02-01T04:55:58Z

+        this.isDone = true;
+    }
+    public void unmarkAsDone () {
+    this.isDone = false;


Should this line be indented?

ArtemiszenN · 2023-02-01T04:59:32Z

+                outputMessage = TASK_ADDED_PREFIX + newEvent.toString() + "\n\t"
+                        + getTaskAddedPostfix();
+            } else if (inputText.equals("bye")) {
+                outputMessage = "Bye. Hope to see you again soon!";


Should this line (and other similar lines) have a newline added?

darrenangwx · 2023-02-01T07:46:14Z

@@ -0,0 +1,15 @@
+public class Deadline extends Task{


Perhaps you can look into using the auto formatting feature in Intellij to standardise the spaces after the curly brackets.

darrenangwx · 2023-02-01T07:46:58Z

+import java.util.Scanner;
+
 public class Duke {
+    static Task[] tasks = new Task[100];


Perhaps look into using an ArrayList might be better? It allows the array to be dynamically sized.

darrenangwx · 2023-02-01T07:47:50Z

+        String outputMessage;
+        while (true) {
+            inputText = scanner.nextLine();
+            if (inputText.equals("list")) {


I feel that using a switch statement might make the code cleaner and easier to read.

darrenangwx · 2023-02-01T07:49:03Z

+                String toDoDescription = inputText.split("/")[0].split("todo")[1].trim();
+                Task newTodo = new ToDo(toDoDescription);
+                tasks[Task.numberOfTasks - 1] = newTodo;
+                outputMessage = TASK_ADDED_PREFIX + newTodo.toString() + "\n\t"


Good job on using UPPERCASE for constants.

Branch level 6

Add DataAccess class

maanyos

overall good compliance with code standards
please work on the object-orientedness of the code, currently most of the logic is contained in Duke which makes it hard to read and trace through.
try creating new classes for command, parser etc and refactor code accordingly.
refer to addressbook3 if required

maanyos · 2023-02-18T10:21:38Z

+        printDuke();
+        String input;
+        String outputMessage;
+        while (true) {


use condition here instead of system.Exit later

maanyos · 2023-02-18T10:26:46Z

+    private static final String DUKE_PREFIX = "Duke Error: ";
+
+
+    public static String[] parseCommand (String command) throws InvalidCommandException{


why is there parseCommand in exception class?

Add find feature

Branch a java doc

kristianachwan added 7 commits January 26, 2023 18:17

Update welcome message

1e44177

Add greet, echo, and exit feature

d604700

Add add and list feature

ea35053

Add mark as done feature and Task class

6c9b878

Follow coding standard and refactor repeated code

76d2e4c

Create ToDo, Deadline, Event entities

1c8a1eb

Incorporate adding todo, deadline, event entity

5d62adf

de-yi reviewed Feb 1, 2023

View reviewed changes

ArtemiszenN reviewed Feb 1, 2023

View reviewed changes

kristianachwan added 6 commits February 1, 2023 14:34

Fix formatting

9423d8a

Bug fix empty line + add UI testing

aa5f8b5

Change linebreak into the safer linearSeparator

4fffeda

Fix bug for adding deadline

3cb44ea

Reformat code

02cb628

Reformat code (2)

6f74566

darrenangwx reviewed Feb 1, 2023

View reviewed changes

kristianachwan added 14 commits February 1, 2023 20:44

Refactor using case statement

f9c599b

Fix bug not adding break in case

37eb12a

Add parser to each entity

85f757f

Add exceptions and error handling

374ac57

Organize into packages

3d199c2

Fix UI-testing

0f6fcc6

Improve variables naming

2ca1e40

Adding command and payload model

075e95f

Add unknown command

967378f

Improve code quality

5838b80

Implement ArrayList for storing tasks

21cedfd

Extract methods refactoring

ffc1076

Add delete task feature

5f38dce

Add DataAccess class

2a0f5ab

kristianachwan and others added 6 commits February 15, 2023 01:43

Merge pull request #1 from kristianachwan/branch-Level-6

2fe149c

Branch level 6

Merge branch 'master' into branch-Level-7

220b7b7

Merge pull request #2 from kristianachwan/branch-Level-7

baac899

Add DataAccess class

Resolve error after merging

62219f3

Fix bug writing duke.txt

5a25935

Clean code

3496b8e

maanyos reviewed Feb 18, 2023

View reviewed changes

kristianachwan and others added 13 commits March 1, 2023 00:37

Refactor to more OOP

8a1dba8

Add find feature

2b7328b

Add method header comments

a8e51f7

Merge pull request #3 from kristianachwan/branch-Level-9

08339d6

Add find feature

Syncing with master

f41e223

Merge pull request #4 from kristianachwan/branch-A-JavaDoc

917ba29

Branch a java doc

Add user guide

5d5a498

Fix typo userguide

59d2021

Change user guide filenaming

13b1697

Change filepath of duke.txt

89999d6

Change the format of printing search results

ae2b710

Add line separator

2e3774d

Update minor mistake on UG

89782e8

		@@ -0,0 +1,40 @@
		public class Task {
		protected String description;

		static Task[] tasks = new Task[100];
		static final String TASK_ADDED_PREFIX = "Got it. I've added this task:\n\t";

		private static final String DUKE_PREFIX = "Duke Error: ";


		public static String[] parseCommand (String command) throws InvalidCommandException{

Conversation

kristianachwan commented Feb 1, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ArtemiszenN left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maanyos left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants