[Nguyen Quang Anh] iP by quanganh2810 · Pull Request #202 · nus-cs2113-AY2223S2/ip

quanganh2810 · 2023-01-31T17:59:55Z

No description provided.

… mark and unmark task

…compliance with coding standard

MustafaAH10

Code is overall of good quality and has minimal errors.

MustafaAH10 · 2023-02-01T07:47:19Z

+            if (userCmd.equals("list")) {
                listofItems.listTask();
-            } else if (WordsinUserCmd[0].equals("mark")) {
+            } else if (userCmdasWords[0].equals("mark")) {


userCmdasWords is a bit confusing to reader.

MustafaAH10 · 2023-02-01T07:49:01Z

@@ -0,0 +1,40 @@
+public class TaskManager {
+    private Task[] tasks = new Task[100];
+    private int tasksCount = 0;


Can be taskCount instead of tasksCount to follow naming convention.

MustafaAH10 · 2023-02-01T07:50:00Z

@@ -0,0 +1,40 @@
+public class Task {
+    private String name;
+    private boolean isDone;


Boolean name is good as status is intuitive.

MustafaAH10 · 2023-02-01T07:52:28Z

+        tasksCount++;
+    }
+
+    public void markTask(int id) {


Can consider combining markTask and unmarkTask into one function.

kaceycsn

Looks good! Code generally follows the coding standard. Some suggestions are given.

kaceycsn · 2023-02-01T09:08:34Z

+    }
+
+    public void listTask() {
+        int j = 1;


Consider changing the variable name. Variables named j, k etc. should be used for nested loops only.

Suggested change

int j = 1;

int counter = 1;

kaceycsn · 2023-02-01T09:09:20Z

@@ -0,0 +1,40 @@
+public class TaskManager {
+    private Task[] tasks = new Task[100];


Great! Array specifiers is attached to the type not the variable.

kaceycsn · 2023-02-01T09:09:50Z

+        while (!userCmd.equals("bye")) {
+            String[] userCmdasWords = userCmd.split(" ");
+            System.out.println(userCmdasWords[0]);
+            if (userCmd.equals("list")) {


Perhaps you can consider using switch instead of multiple if-else statements to make your code cleaner and more readable

kaceycsn · 2023-02-01T09:12:04Z

+        this.name = name;
+    }
+
+    public boolean IsDone() {


Consider changing method name. Method names must be in camelCase.

…lines

…ng methods in classes to make code neater

bdthanh

LGTM! However, you should careful with method and variable naming. I can just find several minor coding standard violations then good job! Good luck on your upcoming tasks

bdthanh · 2023-02-14T18:58:07Z

+        } else {
+            return " [E][ ]" + this.getName() + " (from: " + this.startTime
+            + " to: " + this.finishTime + ")";
+        }


else block are unnecessary. You can move the code inside else block out and put it after if block. Same with other if else block

bdthanh · 2023-02-14T18:59:47Z

+    }
+
+    public String toString() {
+        if(this.getIsDone() == true) {


You should add space between if and condition statement

bdthanh · 2023-02-14T19:01:35Z

+    public static void falseInput() {
+        System.out.println("Sorry Duke could not understand your input :> please follow the instructions");
+        printInstructions();
+    }


Method's name should start with a verb for example announceFalseInput. Same with firstWord method below

…nd Storage classes

quanganh2810 added 5 commits January 26, 2023 02:34

Level-0

6118ea3

Add ability to echo input

9877b90

Add the ability to read and store user commands

bc1e77d

Added Task and TaskManager as the class, add Duke's abiity to record,…

012958e

… mark and unmark task

fix some variable-naming issues and fix further formatting issues in …

ba5a640

…compliance with coding standard

MustafaAH10 reviewed Feb 1, 2023

View reviewed changes

kaceycsn reviewed Feb 1, 2023

View reviewed changes

quanganh2810 added 9 commits February 5, 2023 03:30

Add Deadline and Event as subclasses

09c76af

fix commit

dc4925f

Tidy up the Duke class a little bit by refactoring and shorter print …

97f41d1

…lines

Fix error of not tracking Deadline and Event java files/ added toStri…

af773e9

…ng methods in classes to make code neater

Added exceptions to catch error inputs

452032b

Change the way Duke says goodbye

d47c75d

Merge branch 'master' into branch-Level-5

724ee0b

change the way Duke says goodbye

4e75a59

Create package called "Duke" to store all of the classes

3cf1411

bdthanh reviewed Feb 14, 2023

View reviewed changes

quanganh2810 added 11 commits February 27, 2023 13:15

Changing names to comply with the coding standards

c209898

Add the ability to remove tasks and implement using ArrayList

894b7aa

Add ability to write and read to harddrive

dc3db0f

Merge branch 'branch-Level-7'

b6a0710

Add the ability to read and save data in a file called load.txt properly

5fe873f

Create extra classes such that the project is more OOP - Parser, UI a…

99531f8

…nd Storage classes

Add the ability to find task

21db370

Add documentation

08da801

no message

1aaf326

Merge branch 'branch-A-JavaDoc'

c00debc

Updated the readme file

c9abb22

		@@ -0,0 +1,40 @@
		public class TaskManager {
		private Task[] tasks = new Task[100];

Conversation

quanganh2810 commented Jan 31, 2023

Uh oh!

MustafaAH10 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kaceycsn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bdthanh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants