[CS2113T-F12-3] Teaching Assistant's Assistant#46
Conversation
| * Contains a list of `Module` objects currently being managed by the app. | ||
| * `Util` | ||
| * Contains useful methods (e.g. Check if a string is integer/double, convert string to integer/double). | ||
| * `Storage` |
There was a problem hiding this comment.
Youd could add UML diagrams for the Storage function. This will enable your users to understand how data is written and stored by TAA as well as how it is accessed an read as inputs.
|
|
||
| <br> | ||
|
|
||
| ### Add Assessment |
There was a problem hiding this comment.
The description for the implementation of Assessment tends to be a bit wordy and hard to follow. To make it easier for your users to understand this command function you could add an UML sequence diagram like the other commands.
|
|
||
| <br> | ||
|
|
||
| ### Set Marks |
There was a problem hiding this comment.
You could add an example scenario like the other commands so that it is easier for your users to understand how this command works.
| * Defines how a command is to be executed. | ||
| * `ModuleList` | ||
| * Contains a list of `Module` objects currently being managed by the app. | ||
| * `Util` |
There was a problem hiding this comment.
You could further explain in-depth how the util component works. This will help your users get an idea of what util can be used for when they work on your code.
| 9. A message will then be printed out to indicate to the user that the marks have been set successfully. | ||
|
|
||
|
|
||
| ### Set Attendance |
There was a problem hiding this comment.
You could use an UML sequence diagram here as well for easier reference of how this command function works for your users.
| * `StudentList#findStudent(keyword:String)` - Returns an ArrayList of students containing the keyword | ||
|
|
||
| The sequence diagram shown below illustrates how the `add_student` command works: | ||
|  |
There was a problem hiding this comment.
You could maybe add numbering in the diagram so that you can link the steps to the diagram to make it more clear.
There was a problem hiding this comment.
Perhaps you could explain step by step how the add_student command is being parsed and saved.
There was a problem hiding this comment.
You could perhaps split up the uml diagram to include sub parts of the e.g. focuses on the logic only so that the uml diagram could be bigger and clearer. ref: https://se-education.org/addressbook-level3/DeveloperGuide.html
| ## Implementation | ||
| ### Add Module | ||
| The sequence diagram shown below illustrates how the `add_module` command works: | ||
|  |
There was a problem hiding this comment.
Nice description for the steps, but maybe you can add numbering in the diagram and link it to the steps.
|
|
||
| ### Set Marks | ||
| The sequence diagram shown below illustrates how the `set_mark` command works: | ||
|  |
There was a problem hiding this comment.
You could maybe also add numbering for the diagram so that readers can easily refer to the diagram from the steps.
| * `AttendanceList#sortAttendances` - Sorts the attendance in the `attendances` ArrayList in ascending order based on | ||
| lesson number. | ||
|
|
||
| Below is an example scenario of how the set attendance feature behaves at each step: |
There was a problem hiding this comment.
The steps here look a bit chunky, maybe you could split them up into more steps which could help readers digest it better.
conradwee
left a comment
conradwee
left a comment
There was a problem hiding this comment.
this looks like a great job, just make some minor changes and alls good
| @@ -1,38 +1,228 @@ | |||
| # Developer Guide | |||
|
|
||
| ## Design | ||
| ### Architecture | ||
|  |
|
|
||
| <br> | ||
|
|
||
| ### Add Assessment |
There was a problem hiding this comment.
Neatness/correctness:
looks messy
not well-formatted
hard to read/understand
|
|
||
| <br> | ||
|
|
||
| ### Set Marks |
There was a problem hiding this comment.
Use of examples:
Not enough or too many examples e.g., sample inputs/outputs
| lesson number. | ||
|
|
||
| Below is an example scenario of how the set attendance feature behaves at each step: | ||
| * Step 1 - The user executes `set_attendance c/CS2113T s/1 l/1 p/1` to set an attendance to `Present` for student at |
There was a problem hiding this comment.
Neatness/correctness:
looks messy
not well-formatted
hard to read/understand
perhaps some more spacing at a minimum
Nirmaleshwar
left a comment
Nirmaleshwar
left a comment
There was a problem hiding this comment.
Overall a very good job, just a few minor changes but since it's a work in progress, it's well on track.
| ## Instructions for manual testing | ||
|
|
||
| {Give instructions on how to do a manual product testing e.g., how to load sample data to be used for testing} |
There was a problem hiding this comment.
I'm not sure if you're going you add this later but, perhaps adding some simple manual testing directions can guide the person to test functions you've described so far.
| `AttendanceList` implements the following methods: | ||
| * `AttendanceList#getSize()` - Returns the no. of attendance currently in the list. | ||
| * `AttendanceList#getAttendances()` - Returns an ArrayList containing all the attendances. | ||
| * `AttendanceList#getAttendance(lessonNumber:String)` - Returns an attendance with a particular lesson number. | ||
| * `AttendanceList#isValidIndex(index:int)` - Checks if an index is valid w.r.t the `attendances` ArrayList. | ||
| * `AttendanceList#addAttendance(attendance:Attendance)` - Adds an attendance to the `attendances` ArrayList. | ||
| * `AttendnaceList#getAttendnaceIndex(lessonNumInput:String)` - Returns the attendance index in the `attendances` | ||
| ArrayList. | ||
| * `AttendanceList#deleteAttendance(lessonNumInput:String)` - Deletes an attendance with a particular lesson number. | ||
| * `AttendanceList#sortAttendances` - Sorts the attendance in the `attendances` ArrayList in ascending order based on |
There was a problem hiding this comment.
Maybe can consider putting these on a table as they are a bit too hard to read.
| * On app launch: Creates and runs an instance of `Taa`. | ||
| * `UI` | ||
| * Handles UI operations. | ||
| * `Taa` |
There was a problem hiding this comment.
The sequence diagram of TAA has a problem:
The activation bar of Taa should be closed
| * On run: Loads persistent data from `Storage`, receives user input from `UI`, and uses `Parser` to parse the user input. | ||
| * `Parser` | ||
| * Handles input parsing and determines which command to run. | ||
| * `Command` |
There was a problem hiding this comment.
Would it be better to add function notation?
| <br> | ||
|
|
||
| **Interaction between components** | ||
|  |
There was a problem hiding this comment.
It would be better to add the notation of the grey file icon
tttyyzzz
left a comment
tttyyzzz
left a comment
There was a problem hiding this comment.
Overall good uml diagrams with detailed labels. Could use numbering in uml diagrams if it helps in explanation. Perhaps standardise the steps underneath the uml diagrams. Good Job!
| * `Util` | ||
| * Contains useful methods (e.g. Check if a string is integer/double, convert string to integer/double). | ||
| * `Storage` | ||
| * Handles data storage operations (e.g. Reading from and writing to data file). |
There was a problem hiding this comment.
Perhaps adding new Command() upon instantiation
| from the `assessments` ArrayList. | ||
|
|
||
| The sequence diagram shown below illustrates how the `add_assessment` command works: | ||
|  |
There was a problem hiding this comment.
Perhaps adding the 'X' below the addModuleCommand
| ## Implementation | ||
| ### Add Module | ||
| The sequence diagram shown below illustrates how the `add_module` command works: | ||
|  |
There was a problem hiding this comment.
Perhaps deleting the redundant class.
| * `StudentList#findStudent(keyword:String)` - Returns an ArrayList of students containing the keyword | ||
|
|
||
| The sequence diagram shown below illustrates how the `add_student` command works: | ||
|  |
There was a problem hiding this comment.
Perhaps you could explain step by step how the add_student command is being parsed and saved.
| * `StudentList#findStudent(keyword:String)` - Returns an ArrayList of students containing the keyword | ||
|
|
||
| The sequence diagram shown below illustrates how the `add_student` command works: | ||
|  |
There was a problem hiding this comment.
You could perhaps split up the uml diagram to include sub parts of the e.g. focuses on the logic only so that the uml diagram could be bigger and clearer. ref: https://se-education.org/addressbook-level3/DeveloperGuide.html
…g formatting accordingly
Change type of assessment from int to double and update all the strin…
Update TaaClassDiagram and CommandClassDiagram
Change maximumMarks in AssessmentDeserializer to double and check if student comment is valid in StudentDeserializer
…into student-branch
add images to UG
Update comparison of doubles to a higher precision with Double.compare
update formatting for UG
Fix logic error
add object diagram for add student command
edit mark section in dg
update dg contributions in ppp
modify verify in attendance
add author
update dg with new sequence diagrams
Check for decimal places in deserializers and add more tests
…ementation add header to attendance implementation
… add assessment by changing class code
update DG formatting
Add class diagram for assessment list and update sequence diagram for…
add class diagram
edit object diagram
fix minor error in PPP
11 participants
Teaching Assistant's Assistant helps teaching assistants manage details of their students. It is optimised for CLI users so that managing information can be done faster by typing in commands.