[Wee Heng] IP by Decaxical · Pull Request #312 · nus-cs2103-AY2122S2/ip

Decaxical · 2022-02-01T04:05:52Z

DukePlus

"For every minute spent organizing, an hour is earned." – Benjamin Franklin ([source])(https://orderyourlife.com/blogs/blog/28-amazing-quotes-that-will-inspire-you-to-get-organized)

DukePlus helps you organize your tasks in the form of a task list!
It is:

Text-based
Intuitive
~~Useless~~ EXTRAORDINARILY USEFUL

All you have to do to start using this amazing product is:

Download it from here.
Double-click it.
Add ALL your task.
Kick back and relax as DukePro manages your tasks for you 😉

Best part is DukePro ~~costs as much as it's worth. I mean priceless~~ is FREE!

Features:

Managing tasks
Search for relevant tasks
Sort according to the deadline (Coming soon)

If you are a Java Programmer, you can use it to practice Java too. Here's the main method:

public static void main(String[] args) {
        initialize();
        run();
}

Echoes the commands inputted by the user

implemented the ability to add tasks to a list and to display it

Added a new class task to help with marking and unmarking

made Todo, Event and Deadline extend from task

added input.txt and expected.txt and ensure test passed

Implemented DukeInvalidArgumentException and DukeException. handles when todo has no description and invalid command

Allows for deletion of tasks

hqhqhq1 · 2022-02-02T08:59:15Z

+            }
+            Task taskToMark = taskList.get(taskToMarkNumber - 1);
+            taskToMark.markAsDone();
+            System.out.println("Duly noted. The following task has been marked as done");


maybe can add a method displayMark for the print message as what you did earlier 👍

hqhqhq1 · 2022-02-02T09:00:02Z

+            }
+            Task taskToUnmark = taskList.get(taskToUnmarkNumber - 1);
+            taskToUnmark.markAsNotDone();
+            System.out.println("Very well. The following task has been marked as undone");


same as above displayUnmark

hqhqhq1 · 2022-02-02T09:01:55Z

+
+public class Task {
+    String content;
+    boolean markedDone = false;


boolean var can be named as isDone

tonishka · 2022-02-05T07:59:48Z

+    public static void displayTaskList() {
+        if (taskList.isEmpty()) {
+            System.out.println("Your current task list is empty");
+            return;
+        }
+        int taskCounter = 1;
+        System.out.println("These are the current tasks in your list:");
+        for(Task task:taskList) {
+            System.out.printf("%d. %s \n", taskCounter, task.toString());
+            taskCounter++;
+        }
+    }


Perhaps you can use a TaskList object to separate out each user's task lists and bundle away all related methods like displaying/adding/removing to the list?

tonishka · 2022-02-05T08:01:05Z

+
+public class Task {
+    String content;
+    boolean markedDone = false;


Suggested change

boolean markedDone = false;

boolean isMarkedDone = false;

tonishka · 2022-02-05T08:03:02Z

+public class Duke {
+
+    private static ArrayList<Task> taskList;
+    private static Scanner getUserInput;


getUserInput sounds like a method name. Perhaps consider changing it to

Suggested change

private static Scanner getUserInput;

private static Scanner sc;

tonishka · 2022-02-05T08:05:08Z

+    public static String[] parseArguments(String[] arguments) throws DukeInvalidArgumentException {
+        if (arguments.length < 2) {
+            throw new DukeInvalidArgumentException("There appears to be invalid arguments");
+        }
+
+        return arguments[1].split(" /([Aa][Tt]|[Bb][Yy]) ", 2);
+    }


Maybe have some JavaDoc comments to explain non-trivial public methods?

tonishka · 2022-02-05T08:06:50Z

+package duke;
+
+import duke.exceptions.DukeInvalidArgumentException;
+import duke.tasks.*;


Perhaps list all imported classes explicitly?

Duke is now able to save and load the tasklist across different sessions

Deadline and Event tasks now take in LocalDateTime

This reverts commit a2ce70c, reversing changes made to 74a00d1.

This reverts commit 74a00d1.

This reverts commit 738ca50.

This reverts commit 3f0f903.

This reverts commit e6993ef.

Added functionality for storage to load tasks time as localdatetime

Extracted TextUI for interactions with user, Storage to load and save tasklist, Parser to parse inputs and Tasklist which contains tasklist operations

Removed unnecessary imports and fixed formatting

Added JUnit test for Parser parseCommand() and all functions in Task. Also removed redundant functions from TaskList

Rectified mistake in Intellij compiler and fixed related bugs like text blocks. fixed minor bugs like mark, unmark and delete allowing exceed of size. Improve UI

Added Java documentation and fixed a bug: delete command displaying wrong task being deleted.

Deleted unnecessary lines. Shortened code. Renamed variables.

Accommodate different time format in saveData

Allows users to search for tasks based on content. Added a toString() for TaskList and removed DisplayTaskList() from ListCommand

Javadoc for Find Command and related changes

Changed mainClassName in build.gradle

use FXML. Added resources and images.

Lack of assertions Certain assumptions at various points in the code needs to be checked Use assert method in java to validate assumptions like input Let's add relevant assertions

Overlook certain aspects of code quality Make code more readable and standardizing code formats Extracting certain functions and adopt "drill down" function approach Let's adhere to the code quality in the textbook

This reverts commit eb1d240.

This reverts commit 75e98b3.

…into branch-A-Assertions

Overlook certain aspects of code quality Make code more readable and standardizing code formats Extracting certain functions and adopt "drill down" function approach Let's adhere to the code quality in the textbook

Update Code Quality

Add Assertions

Duke now has a sort command sort command displays tasks based on what type of task they are and in order of when they are due. Task happening sooner are displayed first.

Update so Duke notifies user if a certain type of event is not in the list

Added userguide on how to quick start, features and command summary

Added bubble message. Change image. Reduced window size.

Removed Data

parseindex and parseDatetime throws error if not parsable

damithc and others added 8 commits July 29, 2021 20:30

Add Gradle support

d839859

implement echoes

6a815ae

Echoes the commands inputted by the user

List ability

a716a9b

implemented the ability to add tasks to a list and to display it

Added mark and unmark task functionality

bb75b50

Added a new class task to help with marking and unmarking

Implement Todo, Event, Deadline functionality

8e19494

made Todo, Event and Deadline extend from task

Text-UI-Testing update

b38e28d

added input.txt and expected.txt and ensure test passed

Implemented DukeExceptions

fafdd62

Implemented DukeInvalidArgumentException and DukeException. handles when todo has no description and invalid command

Added delete commannd

eb04bc7

Allows for deletion of tasks

hqhqhq1 reviewed Feb 2, 2022

View reviewed changes

tonishka reviewed Feb 5, 2022

View reviewed changes

Decaxical added 20 commits February 8, 2022 18:53

Added Saving functionality

74a00d1

Duke is now able to save and load the tasklist across different sessions

Update Duke to recognize dates

738ca50

Deadline and Event tasks now take in LocalDateTime

Merge branch 'branch-Level-8'

a2ce70c

Revert "Merge branch 'branch-Level-8'"

3f0f903

This reverts commit a2ce70c, reversing changes made to 74a00d1.

Revert "Added Saving functionality"

e6993ef

This reverts commit 74a00d1.

Revert "Update Duke to recognize dates"

7f7c12f

This reverts commit 738ca50.

Merge branch 'branch-Level-7'

39e0e6f

Revert "Revert "Merge branch 'branch-Level-8'""

12cc23e

This reverts commit 3f0f903.

Revert "Revert "Added Saving functionality""

5aef82a

This reverts commit e6993ef.

Storage save and load datetime

6925a3a

Added functionality for storage to load tasks time as localdatetime

Extracted TextUI, Parser, Tasklist and Command into separate classes

53d55f8

Extracted TextUI for interactions with user, Storage to load and save tasklist, Parser to parse inputs and Tasklist which contains tasklist operations

Cleaned up imports and packages

5ecd726

Removed unnecessary imports and fixed formatting

Added JUnit tests for parser and Task

c910dac

Added JUnit test for Parser parseCommand() and all functions in Task. Also removed redundant functions from TaskList

Changed compile version from java 15 to java 11

c3ab2f1

Rectified mistake in Intellij compiler and fixed related bugs like text blocks. fixed minor bugs like mark, unmark and delete allowing exceed of size. Improve UI

minor UI improvement

0ccd1dc

Added Java documentation

788eebd

Added Java documentation and fixed a bug: delete command displaying wrong task being deleted.

Updated to uphold Coding Standard

cef55d4

Deleted unnecessary lines. Shortened code. Renamed variables.

Added parseSaveDateTime

2cccc29

Accommodate different time format in saveData

Added FindCommand

299caf5

Allows users to search for tasks based on content. Added a toString() for TaskList and removed DisplayTaskList() from ListCommand

Merge branch 'branch-A-JavaDoc'

8b673af

Decaxical and others added 30 commits February 18, 2022 09:44

Merge branch 'branch-Level-9'

60c99d4

Updated Javadoc

8c11904

Javadoc for Find Command and related changes

Merge branch 'add-gradle-support'

60aedd2

Updated gradle

7812b25

Changed mainClassName in build.gradle

Add GUI prototype

1fc28b2

use FXML. Added resources and images.

Add Assertions

75e98b3

Lack of assertions Certain assumptions at various points in the code needs to be checked Use assert method in java to validate assumptions like input Let's add relevant assertions

Update Code Quality

eb1d240

Overlook certain aspects of code quality Make code more readable and standardizing code formats Extracting certain functions and adopt "drill down" function approach Let's adhere to the code quality in the textbook

Revert "Update Code Quality"

81ef77c

This reverts commit eb1d240.

Revert "Update Code Quality"

ee58544

This reverts commit eb1d240.

Revert "Add Assertions"

f9b1f09

This reverts commit 75e98b3.

Merge branch 'branch-A-Assertions' of https://github.com/Decaxical/ip …

66a2967

…into branch-A-Assertions

Update Code Quality

3b45581

Overlook certain aspects of code quality Make code more readable and standardizing code formats Extracting certain functions and adopt "drill down" function approach Let's adhere to the code quality in the textbook

Merge pull request #2 from Decaxical/branch-A-CodeQuality

348dc72

Update Code Quality

Merge pull request #3 from Decaxical/branch-A-Assertions

6aa3f90

Add Assertions

Added Sort Functionality

fdc06cf

Duke now has a sort command sort command displays tasks based on what type of task they are and in order of when they are due. Task happening sooner are displayed first.

Minor update for SortCommand

0ea16b8

Update so Duke notifies user if a certain type of event is not in the list

Updated User Guide

d1cc88c

Added userguide on how to quick start, features and command summary

Set theme jekyll-theme-slate

ad7f24e

Set theme jekyll-theme-slate

95a600b

Set theme jekyll-theme-minimal

42acf6d

Update README.md

8b5e894

Set theme jekyll-theme-midnight

fdd2bc2

Update User Guide

e187739

Update User Guide

1467de4

Update User Guide format

ace9d19

Improved GUI

bc87403

Added bubble message. Change image. Reduced window size.

Added UI.png

d830809

Minor update to User Guide format

5b8d45b

Removed Data

Minor bug fix update

4ac0813

parseindex and parseDatetime throws error if not parsable

Update User Guide

11ca41c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Wee Heng] IP#312

[Wee Heng] IP#312
Decaxical wants to merge 58 commits into
nus-cs2103-AY2122S2:masterfrom
Decaxical:master

Decaxical commented Feb 1, 2022 •

edited

Loading

Uh oh!

hqhqhq1 Feb 2, 2022

Uh oh!

hqhqhq1 Feb 2, 2022

Uh oh!

hqhqhq1 Feb 2, 2022

Uh oh!

tonishka Feb 5, 2022

Uh oh!

tonishka Feb 5, 2022

Uh oh!

tonishka Feb 5, 2022

Uh oh!

tonishka Feb 5, 2022

Uh oh!

tonishka Feb 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	private static Scanner getUserInput;
	private static Scanner sc;

Conversation

Decaxical commented Feb 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DukePlus

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Decaxical commented Feb 1, 2022 •

edited

Loading