[Teh Kok Hoe] iP by tehkokhoe · Pull Request #309 · nus-cs2103-AY2122S2/ip

tehkokhoe · 2022-01-31T04:12:42Z

No description provided.

Fix display

Change the enum accessor so that it is accessible. Add error handling to prevent program from terminating due to illegal user input. Change display to look neater.

Add a semi-automated test to check correctness of code and reduce human error.

Add Exception class to deal with exceptions unique to program.

Add delete feature to remove a task from the list.

Add test cases for delete feature to ensure correct display an exception handling

Add toRecord method for save method to write in a different display from the output on console

This reverts commit d355645.

Add toRecord method for save method to write in a different display from the output on console

Add save method so that whenever list is changed, it is updated to a text file. Adjust code to fit coding standard.

Adjust code to fit coding standard

bakano98

A few coding standard violations, but other than that, nothing too huge. Remember to put everything into a package.
LGTM after fixing these.

bakano98 · 2022-02-02T12:07:40Z

+import java.util.*;
+
 public class Duke {
+    enum Command {


Good to see you're using enums for this! Keep it up.

bakano98 · 2022-02-02T12:09:43Z

@@ -0,0 +1,50 @@
+public class Task {
+    private String task;
+    private boolean done;


According to the coding standards, this should be named isDone

bakano98 · 2022-02-02T12:12:20Z

+        System.out.println("    Hello! I'm Duke");
+        System.out.println("    What can I do for you?");
+        System.out.println("    ____________________________________________________________");
+        boolean StillIn = true;


Use camelCase to name variables, and booleans should be of the form isSomething. You could possibly rename this to isStillIn

bakano98 · 2022-02-02T12:13:49Z

+            System.out.println("    ____________________________________________________________");
+            try {
+                switch (cmd) {
+                    case BYE:


case should not be indented. It should be on the same line as switch

bakano98 · 2022-02-02T12:14:51Z

                + "| |_| | |_| |   <  __/\n"
                + "|____/ \\__,_|_|\\_\\___|\n";
        System.out.println("Hello from\n" + logo);
+        System.out.println("    ____________________________________________________________");


Instead of using 4 spaces, you can consider using \t instead for tab

bakano98 · 2022-02-02T12:17:39Z

@@ -1,10 +1,166 @@
+import java.util.*;


Two things here:

Keep everything in a package

Only import things that are needed to be used. Avoid using wildcard imports

bakano98 · 2022-02-02T12:19:50Z

@@ -0,0 +1,51 @@
+import java.io.BufferedReader;


Not too sure if FastReader is required here, but good consideration!

bakano98 · 2022-02-02T12:23:08Z

+        boolean StillIn = true;
+        FastReader fr = new FastReader();
+        ArrayList<Task> list = new ArrayList<Task>(100);
+        while(StillIn) {


I think you need to put spacing between the brackets and each while and each if. You only do not use spaces when it is a function/method declaration

Allow dates to be recognized as 'Date' objects to allow more capabilities like sorting around dates

# Conflicts: # src/main/java/Duke.java

Adjust how date works due to complement save implementation

Seperate operations into different classes that do specific things

Fix how date is parsed in event so that it can read the two dates regardless of whitespace between the seperator '-' and the date

Package all classes into one package

Add exception handler for invalid commands by telling user command is invalid and then waits to receive next user input

Let parseCommand throw IllegalArgumentException when receive invalid user input

Add JUnit tests for invalid commands and check if bye command quits program

Add checkstyle tests to ensure coding standard

Add JavaDoc to allow people to use program easily

Fix coding standards for improved readability

Add find function so users can easily filter tasks with specific keywords

# Conflicts: # src/main/java/duke/FastReader.java # src/main/java/duke/UI.java

Add JavaDoc for find methods for developer clarity

Add GUI so it is more accessible

Adjust JavaDoc for GUI

Curent code might not be able to detect some bugs So that major bugs can be detected when code is changed in the future Add some asserts to ensure that responses should not be empty for most commands Assert is low cost and is worth the extra security

Users can add duplicate tasks into the list Using equals and contain methods allows duplicate checking Easy to implement and understand

Change the user picture and input text to be always at the bottom of the dialog box, and constantly refreshes as users shouldn't have to know what input they have previously typed, and can infer by just looking at Duke's output

Add User Guide for users to use program comprehensively

tehkokhoe added 21 commits January 19, 2022 16:35

Added a FastReader

db7b3b9

Level-1

f5cc97c

Level-2

3a03048

added new Class Task

98dd74f

Level-3

82e3f0b

Level-4 Added enum and additional functions

666bf39

added a default constructor

3e42bcc

Added Deadline class

2623e50

added Event class

2f2eae3

added ToDo class

c6c76f9

Remove spaces on toString() method

7253df2

Fix display

Update accessor of enum, add error handling, and change display.

cd2cec9

Change the enum accessor so that it is accessible. Add error handling to prevent program from terminating due to illegal user input. Change display to look neater.

Add test.

074b3d5

Add a semi-automated test to check correctness of code and reduce human error.

Add DukeException class

220ea0d

Add Exception class to deal with exceptions unique to program.

Add delete feature

575afdb

Add delete feature to remove a task from the list.

Add test cases for delete feature

53d3490

Add test cases for delete feature to ensure correct display an exception handling

Add different display method for tasks for record purposes

d355645

Add toRecord method for save method to write in a different display from the output on console

Revert "Add different display method for tasks for record purposes"

fb0bb08

This reverts commit d355645.

Add different display method for tasks for record purposes

613ba0f

Add toRecord method for save method to write in a different display from the output on console

Add save method and fix to coding standard

7ab38ce

Add save method so that whenever list is changed, it is updated to a text file. Adjust code to fit coding standard.

Fix code to coding standard

c5d5d5e

Adjust code to fit coding standard

bakano98 reviewed Feb 2, 2022

View reviewed changes

tehkokhoe added 8 commits February 8, 2022 22:49

Allow dates to be recognized as the object 'Date'

d418108

Allow dates to be recognized as 'Date' objects to allow more capabilities like sorting around dates

Fix coding standards

74b2b4d

Merge branch 'branch-Level-8'

0fe362e

# Conflicts: # src/main/java/Duke.java

Adjust how date is displayed and recorded

70a8771

Adjust how date works due to complement save implementation

Make program more OOP like

603ab96

Seperate operations into different classes that do specific things

Fix how date is parsed in event

80b2d81

Fix how date is parsed in event so that it can read the two dates regardless of whitespace between the seperator '-' and the date

Package all classes

4967046

Package all classes into one package

Add exception handler for invalid commands

5c83648

Add exception handler for invalid commands by telling user command is invalid and then waits to receive next user input

tehkokhoe and others added 25 commits February 25, 2022 10:06

Let parseCommand throw IllegalArgumentException

1536f41

Let parseCommand throw IllegalArgumentException when receive invalid user input

Add JUnit tests

1ac0efb

Add JUnit tests for invalid commands and check if bye command quits program

Add checkstyle tests

9ced633

Add checkstyle tests to ensure coding standard

Add JavaDoc

d83efcc

Add JavaDoc to allow people to use program easily

Fix coding standards

1642bc7

Fix coding standards for improved readability

Add find function

dc491b3

Add find function so users can easily filter tasks with specific keywords

Merge branch 'branch-A-JavaDoc'

f9dfa90

Merge branch 'branch-A-CodingStandard'

4fdd0ad

# Conflicts: # src/main/java/duke/FastReader.java # src/main/java/duke/UI.java

Merge branch 'branch-Level-9'

f429a7d

Add JavaDoc for find methods

5bee490

Add JavaDoc for find methods for developer clarity

Make a GFMD

2b64ac0

no message

7145edb

Add GUI

8d43a6c

Add GUI so it is more accessible

Merge branch 'branch-Level-10'

b94ab8b

Adjust JavaDoc

4a75f69

Adjust JavaDoc for GUI

Add assert

4e8656a

Curent code might not be able to detect some bugs So that major bugs can be detected when code is changed in the future Add some asserts to ensure that responses should not be empty for most commands Assert is low cost and is worth the extra security

Merge branch 'branch-A-Assertions'

f70a410

Add duplicate detector

d2fa202

Users can add duplicate tasks into the list Using equals and contain methods allows duplicate checking Easy to implement and understand

Change UI to make more sense

d172734

Change the user picture and input text to be always at the bottom of the dialog box, and constantly refreshes as users shouldn't have to know what input they have previously typed, and can infer by just looking at Duke's output

Set theme jekyll-theme-architect

c78b885

Add User Guide

86ccd94

Add User Guide for users to use program comprehensively

Merge branch 'master' of https://github.com/tehkokhoe/ip

1ec936f

Update dateformat links in User Guide

79edc3b

Adjusted coding quality issues

32b47dc

Add Ui screenshot

1a2789b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Teh Kok Hoe] iP#309

[Teh Kok Hoe] iP#309
tehkokhoe wants to merge 54 commits into
nus-cs2103-AY2122S2:masterfrom
tehkokhoe:master

tehkokhoe commented Jan 31, 2022

Uh oh!

bakano98 left a comment

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

bakano98 Feb 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tehkokhoe commented Jan 31, 2022

Uh oh!

bakano98 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants