[Mark Biju George] iP by markbiju · Pull Request #306 · nus-cs2103-AY2122S2/ip

markbiju · 2022-01-30T11:43:01Z

DukePro

"The best time to plant a tree was 20 years ago. The second best time is now.” - Chinese Proverb (source)

DukePro frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
~~FAST~~ SUPER FAST to use

All you need to do is,

download it from here
open a command line prompt
cd to where the downloaded file is(e.g cd \User\John\Desktop)
type this command: java -jar main.jar
add your tasks.
let it manage your tasks for you 😏

And it is FREE!

Features

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

Here's a sneak peek into what's going on behind the scenes😏

public static void main(String[] args) {
        new Duke("data/tasks.txt").run();
    }

LowJiaHao99

Overall, this is a pretty good effort in following Java Coding Standards closely. The code is pretty clean and simple and it helps to improve readability. Some names of the variable can be improved to further enhance it. There are also some inconsistency, that needs addressing, in regards to the way you organize your code.

Other than that, good job!! 👍

LowJiaHao99 · 2022-02-01T05:26:30Z

-                + "|____/ \\__,_|_|\\_\\___|\n";
-        System.out.println("Hello from\n" + logo);
+    public static void main(String[] args) throws DukeException {
+        Scanner myObj = new Scanner(System.in);


Would "scanner" be a better variable name here?

LowJiaHao99 · 2022-02-01T05:36:19Z

+        int counter = 0;
+        ArrayList<Task> tasks = new ArrayList<Task>();
+
+        System.out.println("Hello! I'm Duke");


Would you consider creating a constant final String for these messages to be printed?

LowJiaHao99 · 2022-02-01T05:46:12Z

+            if (input.equals("bye")) {
+                System.out.println("Bye. Hope to see you again soon!");
+                break;
+            } else if (input.equals("list")){


As per java Coding Standards

Java reserved words should be followed by a white space.

Perhaps you can add a white space between the condition and the open parenthesis to be consistent with the rest of the code.

I notice many similar issues throughout the rest of the code.

LowJiaHao99 · 2022-02-01T05:51:18Z

+                    System.out.println(currentTask);
+                } catch (StringIndexOutOfBoundsException e) {
+                    throw new DukeException("☹ OOPS!!! Please tell me which task you want me to mark as not done!");
+


Perhaps this might be a mistake, do remember to leave out empty lines within a logic block.

I see such mistake appearing occasionally in the rest of the code.

LowJiaHao99 · 2022-02-01T05:56:45Z

-        System.out.println("Hello from\n" + logo);
+    public static void main(String[] args) throws DukeException {
+        Scanner myObj = new Scanner(System.in);
+        int counter = 0;


How about a more intuitive name here? Suggestion: "numOfTasksInList".

LowJiaHao99 · 2022-02-01T06:03:35Z

+                } catch (StringIndexOutOfBoundsException e) {
+                    throw new DukeException("☹ OOPS!!! Please tell me which task to mark as done!");
+                }
+


Are the empty lines used to differentiate between the next condition in the user input processing? This is a pretty good style as it notifies readers/reviewers of the change in logic.

LowJiaHao99 · 2022-02-01T06:07:34Z

+        this.isDone = false;
+    }
+
+    public String getStatusIcon() {


I like the way you name this method. It is short, direct and natural.

Much better than getIsDone() which is what I named mine. 😅

LowJiaHao99 · 2022-02-01T06:16:28Z

+    }
+
+    @Override
+    public String toString() {


I like the use of toString() to print details of the task. The method name itself is already specific to its action and it is a built-in method in all java objects.

LowJiaHao99 · 2022-02-01T06:25:58Z

+
+    public Deadline(String description, String by) {
+        super(description);
+        this.by = by;


Perhaps this variable name can be more specific? One might mistake 'by' as 'added by' instead of 'complete by'.

LowJiaHao99 · 2022-02-01T06:29:07Z

+                    }
+                } catch(ArrayIndexOutOfBoundsException e) {
+                    throw new DukeException("☹ OOPS!!! Please provide a timing for your event.");
+                }


Perhaps this might have been missed during checks, did you made a mistake and left out a empty white line to separate the if-else logic blocks?

paing-oo · 2022-02-02T16:38:40Z

+            f.createNewFile();
+        }
+
+        while (true) {


Perhaps, parsing user inputs could be done in another class called Parser for more abstraction and OOP.

paing-oo · 2022-02-02T16:39:31Z

+                    int toBeMarked = Integer.parseInt(input.substring(5));
+                    Task currentTask = tasks.get(toBeMarked - 1);
+                    currentTask.markAsDone();
+                    System.out.println("Nice! I've marked this task as done:");


Perhaps, printing of messages could be done in another Ui class for better abstraction and OOP.

paing-oo · 2022-02-02T16:41:04Z

+            f.createNewFile();
+        }
+
+        while (true) {


Perhaps, this code block is too long, could work towards better abstraction overall.

Parsing and storage may occur differently if there are more spaces/unexpected input Assertions are needed to test whether parsing and storage is working properly Add assertions in parts of storage and parser code to enforce testing. Let's observe the results of these assertions using different inputs

Some lines are too long. They need to be shortened to improve readability. Line breaks are placed such that longer lines of code are broken down into shorter segments

Add assertions

Branch A-CodeQuality

damithc and others added 9 commits July 29, 2021 20:30

Add Gradle support

d839859

Update Duke.java

88c8d20

Update Duke.java

6a2ea62

Update Duke.java

8d817b0

Level-4

b8c4536

Level-4 upd

0eaf074

A-TextUiTesting

a5fd6ec

Level-5

0f0b793

Update Duke.java

3a748c6

markbiju changed the title ~~[Mark Biju George]~~ [Mark Biju George] iP Jan 30, 2022

LowJiaHao99 reviewed Feb 1, 2022

View reviewed changes

markbiju16 added 3 commits February 2, 2022 02:20

Level-7

f1e27b0

Level-8

3edf9ae

Merge branch 'branch-Level-8'

2466584

paing-oo reviewed Feb 4, 2022

View reviewed changes

markbiju16 added 15 commits February 6, 2022 06:02

A-MoreOOP

987ae8f

update A-MoreOOP

91a36da

Delete AddCommand.java

83901c6

A-Packages

ab034ad

A-JUnit

edcb4fc

Delete file.txt

eb2a949

A-Jar

cd19b3c

branch-A-JavaDoc

a61bb16

branch-A-CodingStandard

4440da8

Level-9

3430097

Merge branch 'branch-A-CodingStandard'

a502950

Merge branch 'branch-Level-9'

5a5a5a0

Merge branch 'add-gradle-support'

c6b7c86

Level-10

e11f89b

Update Storage.java

9c12c96

markbiju16 and others added 30 commits February 19, 2022 15:31

update Ui

5f2d63d

Update tasks.txt

8255963

Update build.gradle

f3bb3d2

update A-Jar

53ed0bf

update Unmark

dc7bd54

Update find

690237a

Update delete

6cb9827

Update Ui.java

df4e00f

Merge branch 'branch-Level-10'

8ae349f

Improve code quality

3e5b53a

Some lines are too long. They need to be shortened to improve readability. Line breaks are placed such that longer lines of code are broken down into shorter segments

Update Deadline.java

5dc99cf

Update Deadline.java

7b9e93d

Merge branch 'master' into branch-A-Assertions

c13f1a0

Merge pull request #2 from markbiju/branch-A-Assertions

134e81c

Add assertions

Merge branch 'master' into branch-A-CodeQuality

7cab92e

Merge pull request #3 from markbiju/branch-A-CodeQuality

be9a892

Branch A-CodeQuality

Update deadline saving

d93a64d

Merge branch 'master' of https://github.com/markbiju/ip

84784f9

Update deadline saving

ad26dcd

BCD-Extension

9124b44

Update README.md

0613f16

Ui.png

354d8b1

Update README.md

aacf706

Update README.md

6deb38d

Update README.md

0411ea5

Update SnoozeCommand.java

046ca8f

Update README.md

0cf6b0c

Update Parser.java

dd9d9a3

Update Parser.java

d84593a

Conversation

markbiju commented Jan 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DukePro

Uh oh!

LowJiaHao99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

markbiju commented Jan 30, 2022 •

edited

Loading